-
Notifications
You must be signed in to change notification settings - Fork 2.9k
pull-kubernetes-scheduler-perf: use -benchtime=1x #36294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
pull-kubernetes-scheduler-perf: use -benchtime=1x #36294
Conversation
pohly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @dom4ha
|
You should also modify the value here (for a periodic job): test-infra/config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml Line 761 in 612e3f8
|
Update scheduler benchmark parameters to use -benchtime=1x instead of -benchtime=1ns to explicitly run benchmarks only once.
3b480e2 to
0f93569
Compare
Thanks for pointing out! Done. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bart0sh, macsko, pohly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @wojtek-t |
Update scheduler benchmark parameters to use
-benchtime=1x instead of -benchtime=1ns to explicitly run benchmarks one time.
This is a follow-up PR requested in this k/k PR
/cc @pohly