Skip to content

Conversation

@bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Jan 23, 2026

Update scheduler benchmark parameters to use
-benchtime=1x instead of -benchtime=1ns to explicitly run benchmarks one time.

This is a follow-up PR requested in this k/k PR

/cc @pohly

@k8s-ci-robot k8s-ci-robot requested a review from pohly January 23, 2026 10:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 23, 2026
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @dom4ha

@github-project-automation github-project-automation bot moved this to Needs Final Approver in SIG Scheduling Jan 23, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2026
@macsko
Copy link
Member

macsko commented Jan 23, 2026

You should also modify the value here (for a periodic job):

Update scheduler benchmark parameters to use -benchtime=1x
instead of -benchtime=1ns to explicitly run benchmarks only once.
@bart0sh bart0sh force-pushed the PR085-set-benchtime-1x-scheduler-perf branch from 3b480e2 to 0f93569 Compare January 25, 2026 08:25
@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 25, 2026
@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 25, 2026

@macsko

You should also modify the value here (for a periodic job):

Thanks for pointing out! Done.

@macsko
Copy link
Member

macsko commented Jan 26, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bart0sh, macsko, pohly
Once this PR has been reviewed and has the lgtm label, please assign mm4tt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bart0sh
Copy link
Contributor Author

bart0sh commented Jan 26, 2026

/assign @wojtek-t
for sig-scalability approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Needs Final Approver

Development

Successfully merging this pull request may close these issues.

6 participants