Skip to content

pull-kubernetes-scheduler-perf: use -benchtime=1x #36294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bart0sh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pull-kubernetes-scheduler-perf: use -benchtime=1x #36294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,10 +755,9 @@ periodics:
value: "y"
- name: TEST_PREFIX
value: BenchmarkPerfScheduling
# Set the benchtime to a very low value so every test is ran at most once
# even on very powerful machines
# Run benchmark once
- name: BENCHTIME
value: 1ns
value: 1x
# We distinguish which test cases to run with --short, and we want to run longer test cases in this job.
# We have to explicitly disable --short flag because the script enables by default.
- name: SHORT
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-scheduling/sig-scheduling-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ presubmits:
args:
- /bin/sh
- -c
- ./hack/install-etcd.sh && PATH=${PWD}/third_party/etcd:${PATH} make test-integration WHAT=./test/integration/scheduler_perf/... KUBE_CACHE_MUTATION_DETECTOR=false KUBE_TIMEOUT=--timeout=3h55m ETCD_LOGLEVEL=warn KUBE_TEST_ARGS="-run=nothing-because-no-test-has-this-name -benchtime=1ns -bench=BenchmarkPerfScheduling -data-items-dir=${ARTIFACTS}" SHORT='--short=false' KUBE_PRUNE_JUNIT_TESTS=false
- ./hack/install-etcd.sh && PATH=${PWD}/third_party/etcd:${PATH} make test-integration WHAT=./test/integration/scheduler_perf/... KUBE_CACHE_MUTATION_DETECTOR=false KUBE_TIMEOUT=--timeout=3h55m ETCD_LOGLEVEL=warn KUBE_TEST_ARGS="-run=nothing-because-no-test-has-this-name -benchtime=1x -bench=BenchmarkPerfScheduling -data-items-dir=${ARTIFACTS}" SHORT='--short=false' KUBE_PRUNE_JUNIT_TESTS=false
# We need to constraint compute resources so all the tests
# finish approximately at the same time. More compute power
# can increase scheduling throughput and make consequent results
Expand Down