Skip to content

[scanner] 🐛 fix: repair WorkloadsExtended test failures#19263

Closed
clubanderson wants to merge 1 commit into
mainfrom
scanner/fix-19258-workloads
Closed

[scanner] 🐛 fix: repair WorkloadsExtended test failures#19263
clubanderson wants to merge 1 commit into
mainfrom
scanner/fix-19258-workloads

Conversation

@clubanderson

@clubanderson clubanderson commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Fixes #19258 (partial — WorkloadsExtended tests)

Repairs 19 failing tests in WorkloadsExtended.test.tsx:

  • Added missing lastUpdated: null to useDeploymentIssues and useDeployments mocks
  • Changed const to let for mock variables that are reassigned in test cases

@clubanderson
[scanner] 🐛 fix: repair WorkloadsExtended test failures
09195c4 
Add missing lastUpdated property to useDeploymentIssues and
useDeployments mocks, and change const to let for mock variables
that are reassigned in tests.

Signed-off-by: clubanderson <club.anderson@gmail.com>
Copilot AI review requested due to automatic review settings June 20, 2026 06:07
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 20, 2026
@netlify

netlify Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 09195c4
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a362e08ec39ac0008e24ddc
😎 Deploy Preview https://deploy-preview-19263.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow

kubestellar-prow Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

Copilot AI reviewed Jun 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes WorkloadsExtended.test.tsx failures by aligning the useMCP hook mocks with the shape expected by the Workloads UI (notably adding lastUpdated: null) and by allowing certain mock arrays to be reassigned across test cases.

Changes:

  • Add lastUpdated: null to useDeploymentIssues and useDeployments mocked return values.
  • Make mocked issue/deployment arrays mutable across tests by switching from const to let.
  • Minor formatting tweak in the skeleton detection test block.

Comment thread web/src/components/workloads/__tests__/WorkloadsExtended.test.tsx
Comment on lines +46 to +49
let mockPodIssues: any[] = []
let mockDeploymentIssues: any[] = []
let mockDeployments: any[] = []
const mockClusters: any[] = []
Comment thread web/src/components/workloads/__tests__/WorkloadsExtended.test.tsx
Comment on lines +451 to 453
const skeletons = screen.getAllByTestId ?
document.querySelectorAll('[class*="skeleton"], [class*="Skeleton"], [class*="animate-pulse"]') :
document.querySelectorAll('[class*="skeleton"], [class*="Skeleton"], [class*="animate-pulse"]')
@clubanderson

clubanderson commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator Author

Scanner CI Analysis 🔍

build-gate ✅ passed. The 43 E2E failures in shard 4 (deep-links.spec.ts, responsive-layouts.spec.ts, UpdateSettings.spec.ts) are pre-existing on main — they appear identically on all 3 scanner PRs (#19262, #19263, #19264) and are unrelated to this PR's WorkloadsExtended test mock fixes.

This PR is ready for merge once the pre-existing E2E flakes are excluded from the required status checks or fixed separately.

This was referenced Jun 20, 2026
Closed
Closed
Merged
@clubanderson

clubanderson commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #19265 which combines this fix with #19264 and #19262. The individual PRs couldn't pass CI independently because the test shards run the full suite and each PR only fixed part of the failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 41 test failure(s) in Coverage Suite run #3815

2 participants

@clubanderson