Skip to content

[scanner] 🐛 fix: add missing time constants barrel export#19264

Closed
clubanderson wants to merge 1 commit into
mainfrom
scanner/fix-19258-imports
Closed

[scanner] 🐛 fix: add missing time constants barrel export#19264
clubanderson wants to merge 1 commit into
mainfrom
scanner/fix-19258-imports

Conversation

@clubanderson

Copy link
Copy Markdown
Collaborator

Fixes #19258 (partial — import errors)

Adds missing export * from './time' to the constants barrel file (web/src/lib/constants/index.ts). After PR #19253 extracted time constants into time.ts, the barrel wasn't updated, causing 5+ tests to fail to load:

  • AlertsContext.core.test.tsx
  • AlertsContext.wave2.test.tsx
  • useDeployMissions.test.ts
  • useSnoozeHooks.test.ts
  • useTokenUsage.test.ts

Add export * from './time' to the constants barrel file, fixing
tests that failed to load due to missing time constant imports
after PR #19253 refactored magic numbers into separate modules.

Signed-off-by: clubanderson <club.anderson@gmail.com>
Copilot AI review requested due to automatic review settings June 20, 2026 06:07
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 20, 2026
@netlify

netlify Bot commented Jun 20, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 93c78d7
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a362e2446c9560008e1118f
😎 Deploy Preview https://deploy-preview-19264.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the web/src/lib/constants barrel export to re-expose the newly extracted time constants module, addressing test-load/import failures introduced when time.ts was added in PR #19253.

Changes:

  • Adds a barrel export for ./time in web/src/lib/constants/index.ts so consumers can import time constants from ../lib/constants.

*/
export * from './network'
export * from './storage'
export * from './time'
@clubanderson

Copy link
Copy Markdown
Collaborator Author

Scanner CI Analysis 🔍

build-gatepassed. The 44 E2E failures in shard 4 (deep-links.spec.ts, responsive-layouts.spec.ts, UpdateSettings.spec.ts) and 2 accessibility test failures are pre-existing on main — they appear identically on all 3 scanner PRs (#19262, #19263, #19264) and are unrelated to this PR's 1-line barrel export fix.

This PR is ready for merge once the pre-existing E2E flakes are excluded from the required status checks or fixed separately.

@clubanderson

Copy link
Copy Markdown
Collaborator Author

Superseded by #19265 which combines this fix with #19263 and #19262. The individual PRs couldn't pass CI independently because the test shards run the full suite and each PR only fixed part of the failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 41 test failure(s) in Coverage Suite run #3815

2 participants