[scanner] 🐛 fix: add missing time constants barrel export#19264
[scanner] 🐛 fix: add missing time constants barrel export#19264clubanderson wants to merge 1 commit into
Conversation
Add export * from './time' to the constants barrel file, fixing tests that failed to load due to missing time constant imports after PR #19253 refactored magic numbers into separate modules. Signed-off-by: clubanderson <club.anderson@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
🐝 Hi @clubanderson! I'm Trusted users — org members and contributors with write access — can mention Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies. |
There was a problem hiding this comment.
Pull request overview
This PR updates the web/src/lib/constants barrel export to re-expose the newly extracted time constants module, addressing test-load/import failures introduced when time.ts was added in PR #19253.
Changes:
- Adds a barrel export for
./timeinweb/src/lib/constants/index.tsso consumers can import time constants from../lib/constants.
| */ | ||
| export * from './network' | ||
| export * from './storage' | ||
| export * from './time' |
|
Scanner CI Analysis 🔍
This PR is ready for merge once the pre-existing E2E flakes are excluded from the required status checks or fixed separately. |
Fixes #19258 (partial — import errors)
Adds missing
export * from './time'to the constants barrel file (web/src/lib/constants/index.ts). After PR #19253 extracted time constants intotime.ts, the barrel wasn't updated, causing 5+ tests to fail to load:AlertsContext.core.test.tsxAlertsContext.wave2.test.tsxuseDeployMissions.test.tsuseSnoozeHooks.test.tsuseTokenUsage.test.ts