Resolves: MTV-5507 | Add post-migration setup phase display and VM access protection#2467
Resolves: MTV-5507 | Add post-migration setup phase display and VM access protection#2467avivtur wants to merge 1 commit into
Conversation
Show the WaitForGuestReboots pipeline step as "Post-migration setup" with a warning alert, differentiate VM migration status, and suppress VM navigation links while Windows VMs are still rebooting after conversion to prevent premature access. Resolves: MTV-5507 Signed-off-by: Aviv Turgeman <aturgema@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
📝 WalkthroughWalkthroughThis PR adds post-migration VM setup detection and guest reboot warnings to the Forklift console plugin. New pipeline step tracking utilities identify when VMs enter the "WaitForGuestReboots" phase, status enums support the new ChangesPost-Migration VM Setup with Guest Reboot Warnings
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
===========================================
- Coverage 36.81% 17.45% -19.37%
===========================================
Files 158 1271 +1113
Lines 2548 23718 +21170
Branches 599 4544 +3945
===========================================
+ Hits 938 4139 +3201
- Misses 1428 19568 +18140
+ Partials 182 11 -171 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@locales/en/plugin__forklift-console-plugin.json`:
- Line 1041: The translation entry for the key 'PostMigrationSetup' currently
exposes the internal key as the user-facing string; update the JSON value for
"PostMigrationSetup" to a human-readable, hyphenated label like "Post-migration
setup" so getVMMigrationStatus() (which calls t('PostMigrationSetup')) shows the
correct UI/filter text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6a2c3e33-892e-4946-baf1-da4b3a196031
📒 Files selected for processing (11)
locales/en/plugin__forklift-console-plugin.jsonlocales/es/plugin__forklift-console-plugin.jsonlocales/fr/plugin__forklift-console-plugin.jsonlocales/ja/plugin__forklift-console-plugin.jsonlocales/ko/plugin__forklift-console-plugin.jsonlocales/zh/plugin__forklift-console-plugin.jsonsrc/plans/details/tabs/VirtualMachines/components/MigrationStatusVirtualMachineList/components/MigrationStatusExpandedPage/components/MigrationProgressTable/MigrationProgressTable.tsxsrc/plans/details/tabs/VirtualMachines/components/MigrationStatusVirtualMachineList/utils/constants.tssrc/plans/details/tabs/VirtualMachines/components/MigrationStatusVirtualMachineList/utils/fields.tsxsrc/plans/details/tabs/VirtualMachines/components/MigrationStatusVirtualMachineList/utils/utils.tssrc/utils/constants.ts
| "Post-migration hook": "Post-migration hook", | ||
| "Post-migration hook job template": "Post-migration hook job template", | ||
| "Post-migration setup": "Post-migration setup", | ||
| "PostMigrationSetup": "PostMigrationSetup", |
There was a problem hiding this comment.
Fix user-facing value for PostMigrationSetup translation key.
getVMMigrationStatus() uses t('PostMigrationSetup'), so this value is shown in UI/filter labels. Keeping it as "PostMigrationSetup" exposes the internal key instead of the intended readable status.
Suggested fix
- "PostMigrationSetup": "PostMigrationSetup",
+ "PostMigrationSetup": "Post-migration setup",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "PostMigrationSetup": "PostMigrationSetup", | |
| "PostMigrationSetup": "Post-migration setup", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@locales/en/plugin__forklift-console-plugin.json` at line 1041, The
translation entry for the key 'PostMigrationSetup' currently exposes the
internal key as the user-facing string; update the JSON value for
"PostMigrationSetup" to a human-readable, hyphenated label like "Post-migration
setup" so getVMMigrationStatus() (which calls t('PostMigrationSetup')) shows the
correct UI/filter text.
Source: Coding guidelines
2 participants
Links
Description
Show the backend's
WaitForGuestRebootspipeline step with user-friendly names and warnings so admins know a Windows VM is still rebooting to install drivers after migration.WaitForGuestReboots→ "Post-migration setup",VirtualMachineCreation→ "Virtual machine creation")WaitForGuestRebootsphase: "Windows VM is installing drivers and configuring network. Multiple reboots are expected."Demo
CC://
Made with Cursor
Summary by CodeRabbit
New Features
Localization