Skip to content

Resolves: MTV-5507 | Add post-migration setup phase display and VM access protection #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avivtur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolves: MTV-5507 | Add post-migration setup phase display and VM access protection #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions locales/en/plugin__forklift-console-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@
"Create with form": "Create with form",
"Create with YAML": "Create with YAML",
"Created ": "Created ",
"Created {{vmName}}": "Created {{vmName}}",
"Created at": "Created at",
"Creating a network mapping": "Creating a network mapping",
"Creating a provider": "Creating a provider",
Expand Down Expand Up @@ -400,13 +401,15 @@
"Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.": "Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.",
"Disabled": "Disabled",
"Disabling shared disk migration requires VDDK to be configured on the VMware provider. Without VDDK, the migration will stall. Either enable VDDK on the provider or keep shared disk migration enabled.": "Disabling shared disk migration requires VDDK to be configured on the VMware provider. Without VDDK, the migration will stall. Either enable VDDK on the provider or keep shared disk migration enabled.",
"Disk allocation": "Disk allocation",
"Disk counter": "Disk counter",
"Disk decryption": "Disk decryption",
"Disk decryption passphrases": "Disk decryption passphrases",
"Disk encryption": "Disk encryption",
"Disk transfer": "Disk transfer",
"Display name": "Display name",
"Distribution": "Distribution",
"Do not access this VM": "Do not access this VM",
"Do not migrate shared disks": "Do not migrate shared disks",
"Do not preserve static IPs": "Do not preserve static IPs",
"Documentation": "Documentation",
Expand Down Expand Up @@ -662,6 +665,7 @@
"If your source provider is VMware, select a Source datastore and a Target storage class": "If your source provider is VMware, select a Source datastore and a Target storage class",
"Ignore network": "Ignore network",
"Image": "Image",
"Image conversion": "Image conversion",
"Impacted resources": "Impacted resources",
"In": "In",
"In some cases, a Raw Copy mode can be used as a fallback. This performs a block-level, byte-for-byte copy of the source disk. It is useful for complex disk layouts or when standard methods fail. Use this with caution as it bypasses filesystem optimizations and should only be used if you fully understand its implications.": "In some cases, a Raw Copy mode can be used as a fallback. This performs a block-level, byte-for-byte copy of the source disk. It is useful for complex disk layouts or when standard methods fail. Use this with caution as it bypasses filesystem optimizations and should only be used if you fully understand its implications.",
Expand All @@ -671,6 +675,7 @@
"Infinidat Infinibox": "Infinidat Infinibox",
"Information concerns": "Information concerns",
"Inherit plan wide setting": "Inherit plan wide setting",
"Initialize": "Initialize",
"Insecure migration means that the transferred data is sent over an insecure connection and potentially sensitive data could be exposed.": "Insecure migration means that the transferred data is sent over an insecure connection and potentially sensitive data could be exposed.",
"Inspect {{count}} VM_one": "Inspect {{count}} VM",
"Inspect {{count}} VM_other": "Inspect {{count}} VMs",
Expand Down Expand Up @@ -1032,13 +1037,16 @@
"Pods not found": "Pods not found",
"Post-migration hook": "Post-migration hook",
"Post-migration hook job template": "Post-migration hook job template",
"Post-migration setup": "Post-migration setup",
"PostMigrationSetup": "PostMigrationSetup",

@coderabbitai coderabbitai Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix user-facing value for PostMigrationSetup translation key.

getVMMigrationStatus() uses t('PostMigrationSetup'), so this value is shown in UI/filter labels. Keeping it as "PostMigrationSetup" exposes the internal key instead of the intended readable status.

Suggested fix 
-  "PostMigrationSetup": "PostMigrationSetup",
+  "PostMigrationSetup": "Post-migration setup",
As per coding guidelines, use consistent hyphenated “post-migration” wording for UI/i18n strings.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"PostMigrationSetup": "PostMigrationSetup",
"PostMigrationSetup": "Post-migration setup",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@locales/en/plugin__forklift-console-plugin.json` at line 1041, The
translation entry for the key 'PostMigrationSetup' currently exposes the
internal key as the user-facing string; update the JSON value for
"PostMigrationSetup" to a human-readable, hyphenated label like "Post-migration
setup" so getVMMigrationStatus() (which calls t('PostMigrationSetup')) shows the
correct UI/filter text.

Source: Coding guidelines

"Power": "Power",
"Powered off": "Powered off",
"Powered on": "Powered on",
"Pre-migration hook": "Pre-migration hook",
"Pre-migration hook job template": "Pre-migration hook job template",
"Precopy interval": "Precopy interval",
"Preferred during scheduling": "Preferred during scheduling",
"Preflight inspection": "Preflight inspection",
"Prerequisites": "Prerequisites",
"Preserve CPU model": "Preserve CPU model",
"Preserve static IPs": "Preserve static IPs",
Expand Down Expand Up @@ -1250,6 +1258,7 @@
"SMB share URL is required": "SMB share URL is required",
"SMB username": "SMB username",
"SMB username is required when using different credentials": "SMB username is required when using different credentials",
"Snapshot consolidation": "Snapshot consolidation",
"Snapshot polling interval": "Snapshot polling interval",
"Some fields may not be supported.": "Some fields may not be supported.",
"Source and target providers": "Source and target providers",
Expand Down Expand Up @@ -1523,6 +1532,7 @@
"Virtual Disk Development Kit (VDDK) container init image path. The path must be empty or a valid container image path in the format of <2>registry_route_or_server_path/vddk:&#8249;tag&#8250;</2>.<4></4><5></5>To accelerate migration and reduce the risk of a plan failing, it is strongly recommended to specify a VDDK init image.": "Virtual Disk Development Kit (VDDK) container init image path. The path must be empty or a valid container image path in the format of <2>registry_route_or_server_path/vddk:&#8249;tag&#8250;</2>.<4></4><5></5>To accelerate migration and reduce the risk of a plan failing, it is strongly recommended to specify a VDDK init image.",
"Virtual Disk Development Kit (VDDK) setup": "Virtual Disk Development Kit (VDDK) setup",
"Virtual machine": "Virtual machine",
"Virtual machine creation": "Virtual machine creation",
"Virtual machines": "Virtual machines",
"Virtualization platform from Red Hat. Currently in maintenance for existing customers only.": "Virtualization platform from Red Hat. Currently in maintenance for existing customers only.",
"Virtualization platform from VMware": "Virtualization platform from VMware",
Expand Down Expand Up @@ -1588,6 +1598,7 @@
"Why don’t my VMs function correctly after a successful migration?": "Why don’t my VMs function correctly after a successful migration?",
"Why is my warm migration stuck?": "Why is my warm migration stuck?",
"Windows": "Windows",
"Windows VM is installing drivers and configuring network. Multiple reboots are expected.": "Windows VM is installing drivers and configuring network. Multiple reboots are expected.",
"With a cold migration, we will move the shut down VM between hosts.": "With a cold migration, we will move the shut down VM between hosts.",
"With a conversion migration, we will convert a virtual machine to a different architecture.": "With a conversion migration, we will convert a virtual machine to a different architecture.",
"With a live migration, we will move an active virtual machine without downtime.": "With a live migration, we will move an active virtual machine without downtime.",
Expand Down
11 changes: 11 additions & 0 deletions locales/es/plugin__forklift-console-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@
"Create with form": "Crear con formulario",
"Create with YAML": "Crear con YAML",
"Created ": "Creado ",
"Created {{vmName}}": "Created {{vmName}}",
"Created at": "Creado en",
"Creating a network mapping": "Creación de una asociación de red",
"Creating a provider": "Creando un proveedor",
Expand Down Expand Up @@ -406,13 +407,15 @@
"Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.": "Determina la frecuencia con la que el sistema comprueba el estado de la creación o eliminación de instantáneas durante la migración en caliente de oVirt. El valor predeterminado es 10 segundos.",
"Disabled": "Desactivado",
"Disabling shared disk migration requires VDDK to be configured on the VMware provider. Without VDDK, the migration will stall. Either enable VDDK on the provider or keep shared disk migration enabled.": "Para deshabilitar la migración de discos compartidos, es necesario configurar VDDK en el proveedor de VMware. Sin VDDK, la migración se detendrá. Habilite VDDK en el proveedor o mantenga habilitada la migración de discos compartidos.",
"Disk allocation": "Disk allocation",
"Disk counter": "Contador de discos",
"Disk decryption": "Descifrado de disco",
"Disk decryption passphrases": "Frases de paso para descifrado de disco",
"Disk encryption": "Cifrado de disco",
"Disk transfer": "Transferencia de disco",
"Display name": "Nombre para mostrar",
"Distribution": "Distribución",
"Do not access this VM": "Do not access this VM",
"Do not migrate shared disks": "No migrar discos compartidos",
"Do not preserve static IPs": "No conservar direcciones IP estáticas",
"Documentation": "Documentación",
Expand Down Expand Up @@ -669,6 +672,7 @@
"If your source provider is VMware, select a Source datastore and a Target storage class": "Si su proveedor de origen es VMware, seleccione un almacén de datos de origen y una clase de almacenamiento de destino",
"Ignore network": "Ignorar la red",
"Image": "Imagen",
"Image conversion": "Image conversion",
"Impacted resources": "Recursos afectados",
"In": "En",
"In some cases, a Raw Copy mode can be used as a fallback. This performs a block-level, byte-for-byte copy of the source disk. It is useful for complex disk layouts or when standard methods fail. Use this with caution as it bypasses filesystem optimizations and should only be used if you fully understand its implications.": "En algunos casos, se puede usar el modo Copia sin formato como alternativa. Este modo realiza una copia a nivel de bloque, byte a byte, del disco de origen. Es útil para diseños de disco complejos o cuando fallan los métodos estándar. Úselo con precaución, ya que omite las optimizaciones del sistema de archivos y solo debe usarse si comprende completamente sus implicaciones.",
Expand All @@ -678,6 +682,7 @@
"Infinidat Infinibox": "Infinidat Infinibox",
"Information concerns": "Preocupaciones sobre la información",
"Inherit plan wide setting": "Heredar la configuración de todo el plan",
"Initialize": "Initialize",
"Insecure migration means that the transferred data is sent over an insecure connection and potentially sensitive data could be exposed.": "Una migración insegura significa que los datos transferidos se envían a través de una conexión insegura y es posible que se expongan datos confidenciales.",
"Inspect {{count}} VM_one": "Inspeccionar{{count}} VM_one",
"Inspect {{count}} VM_many": "Inspect {{count}} VM",
Expand Down Expand Up @@ -1040,13 +1045,16 @@
"Pods not found": "Pods no encontrados",
"Post-migration hook": "Hook posterior a la migración",
"Post-migration hook job template": "Plantilla de trabajo de hook posterior a la migración",
"Post-migration setup": "Post-migration setup",
"PostMigrationSetup": "PostMigrationSetup",
"Power": "Encendido",
"Powered off": "Apagado",
"Powered on": "Encendido",
"Pre-migration hook": "Hook de premigración",
"Pre-migration hook job template": "Plantilla de trabajo de hook previo a la migración",
"Precopy interval": "Intervalo de precopia",
"Preferred during scheduling": "Preferido durante la programación",
"Preflight inspection": "Preflight inspection",
"Prerequisites": "Requisitos previos",
"Preserve CPU model": "Conservar el modelo de CPU",
"Preserve static IPs": "Conservar direcciones IP estáticas",
Expand Down Expand Up @@ -1258,6 +1266,7 @@
"SMB share URL is required": "Se requiere la URL para compartir SMB",
"SMB username": "Nombre de usuario de SMB",
"SMB username is required when using different credentials": "Se requiere un nombre de usuario SMB cuando se utilizan credenciales diferentes",
"Snapshot consolidation": "Snapshot consolidation",
"Snapshot polling interval": "Intervalo de sondeo de instantáneas",
"Some fields may not be supported.": "Es posible que algunos campos no sean compatibles.",
"Source and target providers": "Proveedores de origen y destino",
Expand Down Expand Up @@ -1531,6 +1540,7 @@
"Virtual Disk Development Kit (VDDK) container init image path. The path must be empty or a valid container image path in the format of <2>registry_route_or_server_path/vddk:&#8249;tag&#8250;</2>.<4></4><5></5>To accelerate migration and reduce the risk of a plan failing, it is strongly recommended to specify a VDDK init image.": "Ruta de la imagen de inicialización del contenedor de Virtual Disk Development Kit (VDDK). La ruta debe estar vacía o ser una ruta de imagen de contenedor válida con el formato<2> registry_route_or_server_path/vddk:&#8249;tag&#8250;</2> .<4></4><5></5>. Para acelerar la migración y reducir el riesgo de que un plan falle, se recomienda enfáticamente especificar una imagen de inicialización de VDDK.",
"Virtual Disk Development Kit (VDDK) setup": "Configuración de Virtual Disk Development Kit (VDDK)",
"Virtual machine": "Máquina virtual",
"Virtual machine creation": "Virtual machine creation",
"Virtual machines": "Máquinas virtuales",
"Virtualization platform from Red Hat. Currently in maintenance for existing customers only.": "Plataforma de virtualización de Red Hat. Actualmente en mantenimiento, solo para clientes existentes.",
"Virtualization platform from VMware": "Plataforma de virtualización de VMware",
Expand Down Expand Up @@ -1596,6 +1606,7 @@
"Why don’t my VMs function correctly after a successful migration?": "¿Por qué mis máquinas virtuales no funcionan correctamente después de una migración exitosa?",
"Why is my warm migration stuck?": "¿Por qué está estancada mi migración en caliente?",
"Windows": "Windows",
"Windows VM is installing drivers and configuring network. Multiple reboots are expected.": "Windows VM is installing drivers and configuring network. Multiple reboots are expected.",
"With a cold migration, we will move the shut down VM between hosts.": "Con una migración en frío, moveremos la máquina virtual apagada entre hosts.",
"With a conversion migration, we will convert a virtual machine to a different architecture.": "Con una migración de conversión, convertiremos una máquina virtual a una arquitectura diferente.",
"With a live migration, we will move an active virtual machine without downtime.": "Con una migración en vivo, moveremos una máquina virtual activa sin tiempo de inactividad.",
Expand Down
Loading
Loading