rook-ceph: Pin rook ceph image to v1.16.6

[brianmcarey]

What this PR does / why we need it:

Using the master tag for rook can led to changes breaking the deployment of ceph in kubevirtci

Such as the recent rbac issues:
#1416

Pin the rook image to v1.16.6 and use the image that is mirrored to the kubevirtci quay repo

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @akalenyu @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stu-gott for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dhiller]

will this not create problems whenever people are updating to newer versions - meaning they have to be aware that we are actually mirroring the image to our own registry?

maybe we could try something as patching the yaml with kustomize? This way we could just replace the original yaml with the newer one and the customization would be taken care of when applying it?

[brianmcarey]

This would not be straight forward as gocli applies the yamls - I am not sure we should add an extra step with kustomize.

I could probably change the image using some regex in gocli but then the actual image that is used is hidden away in gocli - having the image here in the manifests is clear for anyone who needs to find it.

[kubevirt-bot]

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
check-provision-k8s-1.31-s390x	b033286	link	false	/test check-provision-k8s-1.31-s390x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[brianmcarey]

@sourcery-ai review

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR pins the Rook Ceph operator image to version v1.16.6 from the quay.io/kubevirtci repository to ensure a stable deployment and prevent breakages caused by using the master tag. Additionally, it updates the extra-pre-pull-images files for k8s versions 1.30, 1.31, 1.32 and 1.33.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Pin the Rook Ceph operator image to a specific version and update the image source.	Changed the Rook Ceph operator image from docker.io/rook/ceph:master to quay.io/kubevirtci/rook-ceph:v1.16.6. This ensures a stable and tested version of Rook Ceph is used, preventing unexpected breakages due to changes in the master tag.	cluster-provision/gocli/opts/rookceph/manifests/operator.yaml
Update extra pre-pull images files.	The extra-pre-pull-images files were updated for k8s versions 1.30, 1.31, 1.32 and 1.33.	cluster-provision/k8s/1.30/extra-pre-pull-images cluster-provision/k8s/1.31/extra-pre-pull-images cluster-provision/k8s/1.32/extra-pre-pull-images cluster-provision/k8s/1.33/extra-pre-pull-images

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @brianmcarey - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment in the code explaining why the rook ceph image is pinned.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[brianmcarey]

@sourcery-ai dismiss

[kubevirt-bot]

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review