Skip to content

rook-ceph: Pin rook ceph image to v1.16.6 #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rook-ceph: Pin rook ceph image to v1.16.6 #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster-provision/gocli/opts/rookceph/manifests/operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ spec:
serviceAccountName: rook-ceph-system
containers:
- name: rook-ceph-operator
image: docker.io/rook/ceph:master
image: quay.io/kubevirtci/rook-ceph:v1.16.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this not create problems whenever people are updating to newer versions - meaning they have to be aware that we are actually mirroring the image to our own registry?

maybe we could try something as patching the yaml with kustomize? This way we could just replace the original yaml with the newer one and the customization would be taken care of when applying it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not be straight forward as gocli applies the yamls - I am not sure we should add an extra step with kustomize.

I could probably change the image using some regex in gocli but then the actual image that is used is hidden away in gocli - having the image here in the manifests is clear for anyone who needs to find it.

args: ["ceph", "operator"]
securityContext:
runAsNonRoot: true
Expand Down
4 changes: 2 additions & 2 deletions cluster-provision/k8s/1.30/extra-pre-pull-images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docker.io/rook/ceph:master
quay.io/kubevirtci/rook-ceph:v1.16.6
ghcr.io/k8snetworkplumbingwg/multus-cni@sha256:c8bfe5bad3b5371a5677feb9e8e162da91b61bcac409c244f6f1b18c801ad006
ghcr.io/k8snetworkplumbingwg/multus-cni:v3.8
ghcr.io/k8snetworkplumbingwg/multus-dynamic-networks-controller@sha256:0bdf7dc9c15bdf7e5760955f05077c23868f3421141e8e623d75cf6b8cf36247
Expand Down Expand Up @@ -42,4 +42,4 @@ quay.io/calico/kube-controllers:v3.26.5
quay.io/calico/node:v3.26.5
quay.io/kubevirtci/install-cni:1.24.4
quay.io/kubevirtci/pilot:1.24.4
quay.io/kubevirtci/proxyv2:1.24.4
quay.io/kubevirtci/proxyv2:1.24.4
4 changes: 2 additions & 2 deletions cluster-provision/k8s/1.31/extra-pre-pull-images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docker.io/rook/ceph:master
quay.io/kubevirtci/rook-ceph:v1.16.6
ghcr.io/k8snetworkplumbingwg/multus-cni@sha256:c8bfe5bad3b5371a5677feb9e8e162da91b61bcac409c244f6f1b18c801ad006
ghcr.io/k8snetworkplumbingwg/multus-cni:v3.8
ghcr.io/k8snetworkplumbingwg/multus-dynamic-networks-controller@sha256:0bdf7dc9c15bdf7e5760955f05077c23868f3421141e8e623d75cf6b8cf36247
Expand Down Expand Up @@ -42,4 +42,4 @@ quay.io/calico/kube-controllers:v3.26.5
quay.io/calico/node:v3.26.5
quay.io/kubevirtci/install-cni:1.24.4
quay.io/kubevirtci/pilot:1.24.4
quay.io/kubevirtci/proxyv2:1.24.4
quay.io/kubevirtci/proxyv2:1.24.4
2 changes: 1 addition & 1 deletion cluster-provision/k8s/1.32/extra-pre-pull-images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docker.io/rook/ceph:master
quay.io/kubevirtci/rook-ceph:v1.16.6
ghcr.io/k8snetworkplumbingwg/multus-cni@sha256:c8bfe5bad3b5371a5677feb9e8e162da91b61bcac409c244f6f1b18c801ad006
ghcr.io/k8snetworkplumbingwg/multus-cni:v3.8
ghcr.io/k8snetworkplumbingwg/multus-dynamic-networks-controller@sha256:0bdf7dc9c15bdf7e5760955f05077c23868f3421141e8e623d75cf6b8cf36247
Expand Down
2 changes: 1 addition & 1 deletion cluster-provision/k8s/1.33/extra-pre-pull-images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docker.io/rook/ceph:master
quay.io/kubevirtci/rook-ceph:v1.16.6
ghcr.io/k8snetworkplumbingwg/multus-cni@sha256:c8bfe5bad3b5371a5677feb9e8e162da91b61bcac409c244f6f1b18c801ad006
ghcr.io/k8snetworkplumbingwg/multus-cni:v3.8
ghcr.io/k8snetworkplumbingwg/multus-dynamic-networks-controller@sha256:0bdf7dc9c15bdf7e5760955f05077c23868f3421141e8e623d75cf6b8cf36247
Expand Down