feat: Accordionコンポーネント対応を追加（後方互換性のためAccordionPanelは保持）#1197
Draft
AtsushiM wants to merge 4 commits into
Draft
Conversation
smarthr-ui v92でAccordionPanelからAccordionへリネームされたため、両方をサポート。 変更内容: - rules/best-practice-for-interactive-element/index.js: Accordion(s)?を追加 - rules/component-name/index.js: 'Accordion$': 'Accordion$'を追加 - test/best-practice-for-interactive-element.js: Accordion(s)?を追加 - test/component-name.js: Accordionのテストケースを追加 - rules/best-practice-for-interactive-element/README.md: Accordionを追加 後方互換性のため、AccordionPanel(s)?は全て保持。 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
AtsushiM
changed the title
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yagimushi
force-pushed
the
feat/add-accordion-support
branch
from
52d1b98 to
8f93a17
Compare
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
後方互換性のためロジックには残すが、ユーザー向けドキュメントには最新のAccordionのみ記載。 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
Author
|
📝 実体としては複数のアイテム(Section)を持つため、名称・マークアップを検討したほうが良さそう。
など |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smarthr-ui v92でAccordionPanelからAccordionへリネームされたため、両方のコンポーネントをサポートするように更新。
変更内容
追加されたコンポーネント
対象ルール
1. best-practice-for-interactive-element
インタラクティブ要素として
Accordion(s)?を追加。変更ファイル:
rules/best-practice-for-interactive-element/index.jstest/best-practice-for-interactive-element.jsrules/best-practice-for-interactive-element/README.md2. component-name
コンポーネント名パターンに
'Accordion$': 'Accordion$'を追加。変更ファイル:
rules/component-name/index.jstest/component-name.js背景
smarthr-ui v92でAccordionPanelからAccordionへのリネームが行われましたが、v91以前のバージョンを使用しているプロジェクトも存在するため、AccordionPanelの記述も残しています。
Test plan
🤖 Generated with Claude Code