Skip to content

feat: Accordionコンポーネント対応を追加（後方互換性のためAccordionPanelは保持） #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AtsushiM wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: Accordionコンポーネント対応を追加（後方互換性のためAccordionPanelは保持） #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32bbb69
feat: Accordionコンポーネント対応を追加（後方互換性のためAccordionPanelは保持）
AtsushiM Apr 6, 2026
8f93a17
docs: readmeから後方互換性の注記を削除
AtsushiM Apr 6, 2026
0d7587a
refactor: 正規表現をAccordion(Panel)?(s)?に統合
AtsushiM Apr 6, 2026
a49bbfb
docs: readmeからAccordionPanelの記述を削除
AtsushiM Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ges/eslint-plugin-smarthr/rules/best-practice-for-interactive-element/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

#### smarthr-uiの対象要素

- AccordionPanel
- Accordion
- Anchor
- Checkbox
- Date
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-smarthr/rules/best-practice-for-interactive-element/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const INTERACTIVE_COMPONENT_NAMES = `(${[
'(L|l)egend(s)$',
'(S|s)elect(s)?',
'(T|t)extarea(s)?',
'AccordionPanel(s)?',
'Accordion(Panel)?(s)?',
'Anchor',
'DisclosureTrigger?',
'DropZone(s)?',
Expand Down
3 changes: 2 additions & 1 deletion packages/eslint-plugin-smarthr/rules/component-name/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ const EXPECTED_NAMES = {
'(S|^s)ection$': 'Section$',
'(S|^s)elect$': 'Select$',
'(T|^t)extarea$': 'Textarea$',
'AccordionPanel$': 'AccordionPanel$',
'Accordion$': 'Accordion$',
'AccordionPanel$': 'AccordionPanel$', // 後方互換性のために残す
'ActionDialogWithTrigger$': 'ActionDialogWithTrigger$',
'Anchor$': 'Anchor$',
'AnchorButton$': 'AnchorButton$',
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-smarthr/test/best-practice-for-interactive-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const INTERACTIVE_COMPONENT_NAMES = `(${[
'(L|l)egend(s)$',
'(S|s)elect(s)?',
'(T|t)extarea(s)?',
'AccordionPanel(s)?',
'Accordion(Panel)?(s)?',
'Anchor',
'DisclosureTrigger?',
'DropZone(s)?',
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-plugin-smarthr/test/component-name.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ ruleTester.run('component-name', rule, {
{ code: `import { FormDialog as HogeDialog } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'HogeDialog', matcher: /FormDialog$/, base: 'FormDialog' }) } ] },
{ code: 'const PaginationFuga = styled(FugaPagination)``', errors: [ { message: messageInheritance({ extended: 'PaginationFuga', matcher: /Pagination$/ }) } ] },
{ code: `import { HogeSideNav as Hoge } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'Hoge', matcher: /Nav$/, base: 'HogeSideNav' }) }, { message: messageImportAs({ extended: 'Hoge', matcher: /SideNav$/, base: 'HogeSideNav' }) } ] },
{ code: 'const AccordionAny = styled(FugaAccordion)``', errors: [ { message: messageInheritance({ extended: 'AccordionAny', matcher: /Accordion$/ }) } ] },
{ code: 'const AccordionPanelAny = styled(FugaAccordionPanel)``', errors: [ { message: messageInheritance({ extended: 'AccordionPanelAny', matcher: /AccordionPanel$/ }) } ] },
{ code: `import { HogeFilterDropdown as Hoge } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'Hoge', matcher: /FilterDropdown$/, base: 'HogeFilterDropdown' }) } ] },
{ code: `const Hoge = styled.fieldset`, errors: [ { message: messageInheritance({ extended: 'Hoge', matcher: /Fieldset$/ }) } ] },
Expand Down