feat: Panelコンポーネント対応を追加#1198
Draft
AtsushiM wants to merge 2 commits into
Draft
Conversation
smarthr-ui v92でBaseからPanelにリネームされたことに対応。 後方互換性のため、Baseの記述も保持。 AccordionPanelやRadioButtonPanelと区別するため、negative lookbehindパターンを使用。 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
否定後読みパターン `(?<!Accordion|RadioButton)Panel$` をシンプルな `Panel$` に変更。 AccordionPanelやRadioButtonPanelで複数エラーが出ることを許容し、テストケースを調整。 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(?<!Accordion|RadioButton)Panel$を使用Changes
rules/component-name/index.js: EXPECTED_NAMESとUNEXPECTED_NAMESにPanel対応を追加test/component-name.js: Panelのテストケースを追加Test plan
Related
🤖 Generated with Claude Code