Skip to content

feat: Panelコンポーネント対応を追加 #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AtsushiM wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: Panelコンポーネント対応を追加 #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76634b
feat: Panelコンポーネント対応を追加（後方互換性のためBaseは保持）
AtsushiM Apr 6, 2026
4061009
refactor: Panel正規表現をシンプルに変更
AtsushiM Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/eslint-plugin-smarthr/rules/component-name/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ const EXPECTED_NAMES = {
'ActionDialogWithTrigger$': 'ActionDialogWithTrigger$',
'Anchor$': 'Anchor$',
'AnchorButton$': 'AnchorButton$',
'Base$': 'Base$',
'Base$': 'Base$', // 後方互換性のために残す
'BaseColumn$': 'BaseColumn$',
'Panel$': 'Panel$',
'Center$': 'Center$',
'Check(B|b)ox$': 'Checkbox$',
'Check(B|b)ox(e)?s$': 'Checkboxes$',
Expand Down Expand Up @@ -154,8 +155,9 @@ const UNEXPECTED_NAMES = {
'(S|^s)ection$': ['(Section)$', unexpectedMessageTemplate ],
'(S|^s)elect$': '(Select)$',
'(T|^t)extarea$': '(Textarea)$',
'Base$': '(Base)$',
'Base$': '(Base)$', // 後方互換性のために残す
'BaseColumn$': '(BaseColumn)$',
'Panel$': '(Panel)$',
'Center$': '(Center)$',
'Check(B|b)ox$': '(Checkbox)$',
'Check(B|b)ox(e)?s$': '(Checkboxes)$',
Expand Down
7 changes: 6 additions & 1 deletion packages/eslint-plugin-smarthr/test/component-name.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,12 @@ ruleTester.run('component-name', rule, {
{ code: 'const SegmentedControlHoge = styled(FugaSegmentedControl)``', errors: [ { message: messageInheritance({ extended: 'SegmentedControlHoge', matcher: '/SegmentedControl$/' }) } ] },
{ code: `import { FormDialog as HogeDialog } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'HogeDialog', matcher: /FormDialog$/, base: 'FormDialog' }) } ] },
{ code: 'const PaginationFuga = styled(FugaPagination)``', errors: [ { message: messageInheritance({ extended: 'PaginationFuga', matcher: /Pagination$/ }) } ] },
{ code: 'const PanelAny = styled(FugaPanel)``', errors: [ { message: messageInheritance({ extended: 'PanelAny', matcher: /Panel$/ }) } ] },
{ code: `import { HogeSideNav as Hoge } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'Hoge', matcher: /Nav$/, base: 'HogeSideNav' }) }, { message: messageImportAs({ extended: 'Hoge', matcher: /SideNav$/, base: 'HogeSideNav' }) } ] },
{ code: 'const AccordionPanelAny = styled(FugaAccordionPanel)``', errors: [ { message: messageInheritance({ extended: 'AccordionPanelAny', matcher: /AccordionPanel$/ }) } ] },
{ code: 'const AccordionPanelAny = styled(FugaAccordionPanel)``', errors: [
{ message: messageInheritance({ extended: 'AccordionPanelAny', matcher: /AccordionPanel$/ }) },
{ message: messageInheritance({ extended: 'AccordionPanelAny', matcher: /Panel$/ }) }
] },
{ code: `import { HogeFilterDropdown as Hoge } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'Hoge', matcher: /FilterDropdown$/, base: 'HogeFilterDropdown' }) } ] },
{ code: `const Hoge = styled.fieldset`, errors: [ { message: messageInheritance({ extended: 'Hoge', matcher: /Fieldset$/ }) } ] },
{ code: `const Hoge = styled(Fieldsets)`, errors: [ { message: messageInheritance({ extended: 'Hoge', matcher: /Fieldsets$/ }) } ] },
Expand Down Expand Up @@ -220,6 +224,7 @@ ruleTester.run('component-name', rule, {
{ code: 'const HogeIcon = styled(Hoge)``', errors: [ { message: messageProperName({ extended: 'HogeIcon', matcher: /(Icon|^(img|svg))$/, suffix: 'Icon', base: 'Hoge' }) } ] },
{ code: `import { ComboBox as ComboBoxHoge } from './hoge'`, errors: [ { message: messageImportAs({ extended: 'ComboBoxHoge', matcher: /Combobox$/, base: 'ComboBox' }) } ] },
{ code: 'const RadioButton = styled(FugaRadioButtonPanel)``', errors: [
{ message: messageInheritance({ extended: 'RadioButton', matcher: /Panel$/ }) },
{ message: messageInheritance({ extended: 'RadioButton', matcher: /RadioButtonPanel$/ }) },
{ message: messageProperName({ extended: 'RadioButton', matcher: /(B|^b)utton$/, sampleMatcher: /(Button)$/, suffix: 'Button', base: 'FugaRadioButtonPanel' }) },
{ message: messageProperName({ extended: 'RadioButton', matcher: /RadioButton$/, sampleMatcher: /(RadioButton)$/, suffix: 'RadioButton', base: 'FugaRadioButtonPanel' }) }] },
Expand Down