fix(vega-backend): allow catalog connector config updates#476
Merged
Conversation
Flynn-Zh
approved these changes
May 19, 2026
…tial update 移除了 connector_config 的不可变字段校验逻辑,放开对数据库、host等配置字段的修改限制,修改后旧资源会在下次发现对齐时标记为stale,新增对应测试用例验证更新行为
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What Changed
Brief description of changes:
connector_configimmutable-field check from catalog update.database,host, and related connection fields while keepingconnector_typeandenabledprotected.connector_config.databasecan be changed throughPUT /catalogs/{id}.Why
connector_config.databasewas treated as immutable. The expected behavior is that catalog config updates should succeed, and old resources should be reconciled by the next discover task.How
immutableFieldsvalidation block fromupdateCatalog.connector_typeimmutability guard.enabledguard, so enable/disable still uses dedicated endpoints.connector_typeandenabledremain unchanged.Testing
Test notes:
go test ./driveradapters ./logics/catalog ./logics/resourceRisk & Rollback
Additional Notes
catalog_handler.go,catalog_handler_test.go, andcatalog.yaml.