Conversation
fixes the tauros
With fix from pknx, bad field-packing hash function
Take 1 less byte to alloc :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces slight changes to how weather conditions are handled in Gen 9 encounters. The key updates include the addition of a new weather type (
Mistreplacing the unusedIntense_Sun), the removal of location-specific weather mappings, and the incorporation of weather compatibility checks directly into encounter records and methods.Weather System Updates:
PKHeX.Core/Legality/Encounters/Templates/Gen9/AreaWeather9.cs: AddedMistas a new weather type and removedIntense_SunandHeavy_Fog(same as Mist, but bitflag is now lesser -- to store the enum as a byte). UpdatedAreaWeather9Extensionsto include compatibility checks for the newMisttype. [1] [2]Encounter Record Enhancements:
PKHeX.Core/Legality/Encounters/Templates/Gen9/EncounterSlot9.cs: AddedWeatheras a required property in theEncounterSlot9record, removing location-based weather mappings and simplifying weather compatibility checks. [1] [2]PKHeX.Core/Legality/Encounters/Templates/Gen9/EncounterOutbreak9.cs: IntroducedWeatheras a property in theEncounterOutbreak9record and updated methods to include weather compatibility checks. Adjusted data parsing logic to account for the new weather property. [1] [2] [3] [4]Legality Verification Adjustments:
PKHeX.Core/Legality/Verifiers/Ribbons/MarkRules.cs: Updated legality checks to use the new weather compatibility methods inEncounterSlot9andEncounterOutbreak9. Removed references to location-based weather mappings and streamlined logic for weather-related mark checks. [1] [2] [3]These changes improve the flexibility and maintainability of weather-related legality checks by centralizing weather compatibility logic within encounter records and removing hardcoded mappings.
pkNX has absorbed the area location/weather permissions of prior commits, and now emits them directly into the encounter objects. See pkNX commits from late June/early July (today).
There are still some edge cases (Kitakami area boost determination for overlapping areas -- which one is the real parent?) and possibly some extra tolerance quirks in Blueberry, but those can be investigated in a separate effort.
Closes #4036 (player onlook weather bleed)