chore: update UI5 from v1 to v2 by mrCherry97 · Pull Request #3542 · kyma-project/busola

mrCherry97 · 2024-12-17T11:33:29Z

Description

Changes proposed in this pull request:

updated all UI5 dependencies to V2
updated React to version 18
refactored components to the UI5 v2 API
adjusted e2e tests
migrated unit and component tests from Vitest to Cypress
replaced spacing from webcomponents-react with corresponding classNames
fixed bugs

Related issue(s)
Closes #3422

Definition of done

The PR's title starts with one of the following prefixes:
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- refactor: A code change that neither fixes a bug nor adds a feature
- test: Adding tests
- chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
Explain clearly why you created the PR and what changes it introduces
All necessary steps are delivered, for example, tests, documentation, merging

* chore: update packages * chore: bump ui5-react * fix: adjust tests to not use enzyme * chore: fix dependencies * fix: remove unused * fix: remove not existing import * chore: add compatibility package

* fix: change render * fix: adjust css names * fix: change imports for Toolbar * fix: change imports for tables * fix: rename list comp. & badge * fix: fix imports

* change some spacing to new classnames * fix merge * pray to god, that everything is working * pray to god, that everything is working * some spacing and iconEnd for ExternalLink * some spacing and iconEnd for SA token * add no-margin class in index.scss * adjust the rest of the spacing * remove unused impott * fix stupid classNames * adjust separatorLine to tsx and use style prop * review changes

* fix: ui5 codemode adjustments * fix: fix imports * fix: fix table imports * fix: fix unused

* fix: adjust dynamicPage * fix: separate actionsBar * fix: fix actions behavior * fix: remove unused * fix: fix classNames * fix: fix empty toolbar & move banners * fix: fix dependency * fix: remove spacing file

* fix: adjust tokens * fix: adjust spacing

* fix: adjust badges type names * fix: fix type mappings * fix: remove console.log

* fix: add 'size' to headers * fix: add size to headers

* remove defaultProps and disableEdit prop from resourcelist * Update src/shared/components/ResourcesList/ResourcesList.js Co-authored-by: Oliwia Gowor <72342415+OliwiaGowor@users.noreply.github.com> --------- Co-authored-by: Oliwia Gowor <72342415+OliwiaGowor@users.noreply.github.com>

* fix: fix styling and alerts * fix: fix unsaved message * fix: fix background in add modules * fix: remove unused * fix: passing props * fix: key error * fix: resources in list

* fix: adjust Preferences modal * fix: move import * fix: opening preferences menu * fix: list props

…e-v2

* fix: key errors * fix: fetch error * fix: monaco worker fix * fix: dynamicPage header error * fix: small fixes * fix: review fixes

* fix: adjust tables * fix: emptyListComp flickering * fix: adjust reset.css

…3524)

* fix: fix flickering on column layout * fix: remove unused * fix: replace DynamicPage with ObjectPage * fix: fix key error * fix: banner height and remove unused * fix: initial render flicker * fix: change to DynamicPage * hotfix * Replace props spread * hotfix * fix: shadow & unused * fix: shadow & sticky tabs * fix: hide button everywhere --------- Co-authored-by: mrCherry97 <mwisnia97@gmail.com> Co-authored-by: akucharska <agata.kucharska@sap.com>

…e-v2

Co-authored-by: Oliwia Gowor <oliwiagowor@gmail.com>

* Fix delete cluster action

* Revert "Merge branch 'main' into ui5-migrate-v2" This reverts commit 79fb867, reversing changes made to 5b7fd61. * fix: selected in lists (#3539) * fix: toasts in dialogs

mrCherry97

~~Clicking APIGateway on the Cluster level is causing busola break~~

src/components/KymaModules/KymaModulesList.js

src/shared/components/Labels/Labels.js

* fix: adjust badges * fix: add checkBeta back

…e-v2

chriskari

looks pretty good to me. I had a thorough look through the files and tested the application but didn't encounter any bugs or styling issues.

akucharska

lgtm

…e-v2

docs/contributor/testing-strategy.md

mrCherry97 · 2025-01-24T08:02:47Z

/hold until #3598

* fix: adjust badges * adjust test

mrCherry97 · 2025-01-27T08:23:50Z

/unhold

…e-v2

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

…e-v2

* fix: undefined in state * fix: stabilize test * fix: stabilize navigation test * fix: stabilize tests? * move wait for cr test

OliwiaGowor and others added 22 commits October 31, 2024 13:44

chore: UI5 bump packages (#3439)

e5930e3

* chore: update packages * chore: bump ui5-react * fix: adjust tests to not use enzyme * chore: fix dependencies * fix: remove unused * fix: remove not existing import * chore: add compatibility package

fix: adjust render, css names and imports (#3440)

527ab33

* fix: change render * fix: adjust css names * fix: change imports for Toolbar * fix: change imports for tables * fix: rename list comp. & badge * fix: fix imports

fix: Ui5 codemod adjustments (#3449)

0ff4119

* fix: ui5 codemode adjustments * fix: fix imports * fix: fix table imports * fix: fix unused

fix: adjust DynamicPageComponent (#3445)

7b1e4dc

* fix: adjust dynamicPage * fix: separate actionsBar * fix: fix actions behavior * fix: remove unused * fix: fix classNames * fix: fix empty toolbar & move banners * fix: fix dependency * fix: remove spacing file

fix: toast adjustments (#3462)

9c39bff

fix: adjust tokens (#3463)

ba9135e

* fix: adjust tokens * fix: adjust spacing

fix: adjust badges (#3464)

ce4764e

* fix: adjust badges type names * fix: fix type mappings * fix: remove console.log

fix: adjust headers size (#3467)

c85f1bd

* fix: add 'size' to headers * fix: add size to headers

fix: spinner size (#3474)

a486ff6

fix: theme (#3475)

c702d0c

fix: adjust forms (#3473)

da69d7c

* fix: fix styling and alerts * fix: fix unsaved message * fix: fix background in add modules * fix: remove unused * fix: passing props * fix: key error * fix: resources in list

fix: adjust Preferences modal (#3476)

57d5921

* fix: adjust Preferences modal * fix: move import * fix: opening preferences menu * fix: list props

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

7a03881

…e-v2

fix: props

dd3e052

fix: objectPageHeader styling and modules card (#3487)

5e543ee

fix: Ui5 console errors (#3486)

bcf9884

* fix: key errors * fix: fetch error * fix: monaco worker fix * fix: dynamicPage header error * fix: small fixes * fix: review fixes

fix: adjust V1 Tables (#3491)

23431fc

* fix: adjust tables * fix: emptyListComp flickering * fix: adjust reset.css

fix: change logo acc name (#3518)

dc93f43

remove unnecessary css code from reset.css & some minor adjustments (#…

3517ff7

…3524)

kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024

mrCherry97 changed the title ~~Ui5 migrate v2~~ chore: update UI5 from v1 to v2 Dec 17, 2024

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

4120fed

…e-v2

kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2024

mrCherry97 and others added 3 commits December 17, 2024 12:46

fix: selected in lists (#3543)

71908da

Co-authored-by: Oliwia Gowor <oliwiagowor@gmail.com>

fix: Fix delete cluster action (#3540)

049a830

* Fix delete cluster action

fix: Toast is hidden behind Dialogs (#3538)

764bf23

* Revert "Merge branch 'main' into ui5-migrate-v2" This reverts commit 79fb867, reversing changes made to 5b7fd61. * fix: selected in lists (#3539) * fix: toasts in dialogs

mrCherry97 commented Jan 21, 2025

View reviewed changes

src/components/KymaModules/KymaModulesList.js Outdated Show resolved Hide resolved

src/shared/components/Labels/Labels.js Show resolved Hide resolved

OliwiaGowor and others added 2 commits January 22, 2025 09:29

fix: UI5 adjust badges (#3619)

80498c9

* fix: adjust badges * fix: add checkBeta back

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

a914c4c

…e-v2

chriskari reviewed Jan 22, 2025

View reviewed changes

akucharska previously approved these changes Jan 23, 2025

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Jan 23, 2025

fix: adjust Web Components to React 18 (#3622)

950b2d6

chriskari dismissed akucharska’s stale review via 950b2d6 January 23, 2025 08:29

kyma-bot removed the lgtm Looks good to me! label Jan 23, 2025

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

b403c39

…e-v2

grego952 reviewed Jan 23, 2025

View reviewed changes

docs/contributor/testing-strategy.md Outdated Show resolved Hide resolved

kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025

fix: adjust badges after overriding functionality (#3627)

1b43fec

* fix: adjust badges * adjust test

kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025

mrCherry97 and others added 2 commits January 27, 2025 09:38

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

6505f3c

…e-v2

Update docs/contributor/testing-strategy.md

2695abb

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>

grego952 previously approved these changes Jan 27, 2025

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Jan 27, 2025

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

f25c4e7

…e-v2

kyma-bot removed the lgtm Looks good to me! label Jan 28, 2025

Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…

44e5d54

…e-v2

OliwiaGowor dismissed grego952’s stale review via 44e5d54 January 28, 2025 19:23

fix: undefined in data sources (#3633)

9d6c74e

* fix: undefined in state * fix: stabilize test * fix: stabilize navigation test * fix: stabilize tests? * move wait for cr test

grego952 approved these changes Jan 29, 2025

View reviewed changes

kyma-bot added the lgtm Looks good to me! label Jan 29, 2025

akucharska approved these changes Jan 29, 2025

View reviewed changes

mrCherry97 merged commit 86b9ab4 into main Jan 29, 2025
17 checks passed

mrCherry97 deleted the ui5-migrate-v2 branch January 29, 2025 09:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update UI5 from v1 to v2#3542

chore: update UI5 from v1 to v2#3542
mrCherry97 merged 60 commits intomainfrom
ui5-migrate-v2

mrCherry97 commented Dec 17, 2024 •

edited by OliwiaGowor

Loading

Uh oh!

mrCherry97 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

chriskari left a comment

Uh oh!

akucharska left a comment

Uh oh!

Uh oh!

mrCherry97 commented Jan 24, 2025

Uh oh!

mrCherry97 commented Jan 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

mrCherry97 commented Dec 17, 2024 • edited by OliwiaGowor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrCherry97 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chriskari left a comment

Choose a reason for hiding this comment

Uh oh!

akucharska left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrCherry97 commented Jan 24, 2025

Uh oh!

mrCherry97 commented Jan 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mrCherry97 commented Dec 17, 2024 •

edited by OliwiaGowor

Loading

mrCherry97 left a comment •

edited

Loading