-
Notifications
You must be signed in to change notification settings - Fork 56
chore: update UI5 from v1 to v2 #3542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 54 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
e5930e3
chore: UI5 bump packages (#3439)
OliwiaGowor 527ab33
fix: adjust render, css names and imports (#3440)
OliwiaGowor cd703c0
chore: adjust spacing to classNames (#3442)
mrCherry97 0ff4119
fix: Ui5 codemod adjustments (#3449)
OliwiaGowor 7b1e4dc
fix: adjust DynamicPageComponent (#3445)
OliwiaGowor 9c39bff
fix: toast adjustments (#3462)
mrCherry97 ba9135e
fix: adjust tokens (#3463)
OliwiaGowor ce4764e
fix: adjust badges (#3464)
OliwiaGowor c85f1bd
fix: adjust headers size (#3467)
OliwiaGowor a565ab1
fix: defaultProps (#3469)
mrCherry97 a486ff6
fix: spinner size (#3474)
mrCherry97 c702d0c
fix: theme (#3475)
OliwiaGowor da69d7c
fix: adjust forms (#3473)
OliwiaGowor 57d5921
fix: adjust Preferences modal (#3476)
OliwiaGowor 7a03881
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
mrCherry97 dd3e052
fix: props
mrCherry97 5e543ee
fix: objectPageHeader styling and modules card (#3487)
mrCherry97 bcf9884
fix: Ui5 console errors (#3486)
OliwiaGowor 23431fc
fix: adjust V1 Tables (#3491)
OliwiaGowor dc93f43
fix: change logo acc name (#3518)
OliwiaGowor 3517ff7
remove unnecessary css code from reset.css & some minor adjustments (…
chriskari 5b7fd61
fix: Busola is flickering when ObjectPage is opened (#3498)
OliwiaGowor 4120fed
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
mrCherry97 71908da
fix: selected in lists (#3543)
mrCherry97 049a830
fix: Fix delete cluster action (#3540)
akucharska 764bf23
fix: Toast is hidden behind Dialogs (#3538)
OliwiaGowor 445f263
Merge branch 'main' into ui5-migrate-v2
mrCherry97 f0cf797
fix: adjust Cypress tests (#3553)
OliwiaGowor 5f41290
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor cedc25c
chore: add unsafe eval for accessibility tests (#3554)
mrCherry97 413b65f
fix: small leftover bugs (#3555)
OliwiaGowor eb90c63
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 16c7efb
feat: migrate UI5 vitest unit tests to cypress component tests (#3551)
chriskari ec75207
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 589bf60
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 0bace38
fix: theme on initial and refresh (#3565)
OliwiaGowor e9ea9fb
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 34644e6
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 150d427
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 600143d
fix: combobox (#3588)
dbadura 6f39790
fix: Command Palette shouldn't navigate when Form is edited (#3583)
OliwiaGowor fcfe6f4
fix: adjust styles (#3595)
OliwiaGowor 62e7294
fix: open dropdown popover correctly (#3594)
chriskari 6d117d1
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor af4f19f
fix: remove unused css & small changes (#3599)
OliwiaGowor dc3bf7c
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 4e5014c
fix: container selector (#3597)
chriskari 2bf6dbf
test: adjust unit test workflow (#3609)
chriskari 3ebc8f7
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 4d7df0c
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
mrCherry97 80498c9
fix: UI5 adjust badges (#3619)
OliwiaGowor a914c4c
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 950b2d6
fix: adjust Web Components to React 18 (#3622)
OliwiaGowor b403c39
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 1b43fec
fix: adjust badges after overriding functionality (#3627)
OliwiaGowor 6505f3c
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
mrCherry97 2695abb
Update docs/contributor/testing-strategy.md
mrCherry97 f25c4e7
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 44e5d54
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
OliwiaGowor 9d6c74e
fix: undefined in data sources (#3633)
OliwiaGowor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { defineConfig } from 'cypress'; | ||
|
|
||
| export default defineConfig({ | ||
| component: { | ||
| screenshotOnRunFailure: false, | ||
| includeShadowDom: true, | ||
| devServer: { | ||
| framework: 'react', | ||
| bundler: 'vite', | ||
| }, | ||
| specPattern: 'src/**/*.cy.{js,jsx,ts,tsx}', | ||
| supportFile: 'cypress/support/component.jsx', | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1.0" /> | ||
| <title>Components App</title> | ||
| </head> | ||
| <body> | ||
| <div data-cy-root></div> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* global Cypress */ | ||
| import React from 'react'; | ||
| import { mount } from 'cypress/react18'; | ||
| import { ThemeProvider } from '@ui5/webcomponents-react'; | ||
| import { MemoryRouter } from 'react-router-dom'; | ||
| import { RecoilRoot } from 'recoil'; | ||
|
|
||
| import i18n from 'i18next'; | ||
| import { initReactI18next } from 'react-i18next'; | ||
| import { I18nextProvider } from 'react-i18next'; | ||
|
|
||
| i18n.use(initReactI18next).init({ | ||
| lng: 'en', | ||
| fallbackLng: false, | ||
| nsSeparator: '::', | ||
| defaultNS: 'translation', | ||
| saveMissing: true, | ||
| interpolation: { | ||
| escapeValue: false, | ||
| }, | ||
| }); | ||
|
|
||
| Cypress.Commands.add( | ||
| 'mount', | ||
| (component, { initializeRecoil, ...options } = {}) => { | ||
| return mount( | ||
| <RecoilRoot initializeState={initializeRecoil}> | ||
| <I18nextProvider i18n={i18n}> | ||
| <MemoryRouter> | ||
| <ThemeProvider>{component}</ThemeProvider> | ||
| </MemoryRouter> | ||
| </I18nextProvider> | ||
| </RecoilRoot>, | ||
| options, | ||
| ); | ||
| }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove it, but it will be nice to have it documented in internal docs, how to do this, in case same problem will appear in the future