fix: Migrator attempts to create schema even when it exists #1608
+2
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@austin-hall-skylight is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
| * tables. | ||
| * | ||
| * This only works on postgres. | ||
| * This only works on postgres and mssql. |
There was a problem hiding this comment.
I have updated the relevant test and tested it manually in my project that is using Kysely. Is there anything else that I need to check to confirm that migrationTableSchema works with mssql?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1552.
Removes call to
createIfNotExistsformigrationTableSchemainensureMigrationTableExistssince it will always be checked inensureMigrationTablesExists. This enables using themigrationTableSchemaproperty inMigratorPropswith MS SQL Server as the migrator will no longer attempt to recreate the schema every time migrations are run.