Skip to content

fix: Migrator attempts to create schema even when it exists #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −8
Open

fix: Migrator attempts to create schema even when it exists #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/migration/migrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,6 @@ export class Migrator {
async #ensureMigrationTableExists(): Promise<void> {
if (!(await this.#doesTableExists(this.#migrationTable))) {
try {
if (this.#migrationTableSchema) {
await this.#createIfNotExists(
this.#props.db.schema.createSchema(this.#migrationTableSchema),
)
}

await this.#createIfNotExists(
this.#props.db.schema
.withPlugin(this.#schemaPlugin)
Expand Down Expand Up @@ -799,7 +793,7 @@ export interface MigratorProps {
* the project, to the end of time or prepare to manually migrate the migration
* tables.
*
* This only works on postgres.
* This only works on postgres and mssql.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the relevant test and tested it manually in my project that is using Kysely. Is there anything else that I need to check to confirm that migrationTableSchema works with mssql?

*/
readonly migrationTableSchema?: string

Expand Down
2 changes: 1 addition & 1 deletion test/node/src/migration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,7 @@ for (const dialect of DIALECTS) {
})
})

if (dialect === 'postgres') {
if (dialect === 'postgres' || dialect === 'mssql') {
describe('custom migration tables in a custom schema', () => {
it('should create custom migration tables in custom schema', async () => {
const [migrator, executedUpMethods] = createMigrations(
Expand Down