Update GPX export path to Documents folder for user accessibility #458
Conversation
Modifies the GPX export path to save files in a user-accessible location. Previously, files were exported to a default location that was not visible to the user, making access difficult. Exports are now saved in the Downloads folder. The solution works up to the latest version, Android 14. Co-Authored-By: Kevin Salazar <[email protected]>
I wanted to provide some context regarding this PR, "Update GPX export path to Downloads folder for user accessibility #458," in relation to PR #443 ("GPX export not working"). While both PRs address the GPX export functionality, there are a few key differences: Export Location: This PR updates the export path to the Downloads folder for improved user accessibility, whereas PR #443 saves files in the Documents directory. UI Message Update: This PR also modifies the message to accurately reflect the new export location, ensuring better clarity for users. That said, if PR #443 is accepted as is, this PR may not be necessary, as both resolve the core issue of the GPX export functionality. However, I believe the choice of export location (Downloads vs. Documents) and the updated UI message could be factors to consider in making the final decision. Let me know if further clarification or adjustments are needed! |
|
Works perfectly! @Andyporras |
|
Hello! |
|
Hi @Andyporras Can you please update your PR. You have some conflicts with the previous PR #451 which was already addressing (part?) of this issue. |
|
In PR #451 storage have been set to DIRECTORY_DOCUMENTS. I think it is a way better idea than download. As download can be messy due to user many downloading files from web, etc. |
Thank you for pointing this out. I’ll review the conflicts with PR #451 and make the necessary updates to ensure compatibility. If we agree that DIRECTORY_DOCUMENTS is a better location, I can adjust this PR to align with the changes introduced in PR #451. I’ll update the implementation accordingly and re-test to ensure everything works seamlessly. I’ll notify you once the conflicts are resolved and the PR is updated. Thank you for the feedback! |
Andyporras
changed the title
Changed the GPX export location to the Documents folder for better organization and user accessibility, as per feedback. Adjusted related strings and resolved conflicts with PR labexp#451
|
I’ve resolved the conflicts and updated the logic to ensure that GPX files are saved in the Documents directory. Additionally, I’ve updated the UI message to "Public directory (in documents)" to make it clear to the user where the files are being stored. Let me know if you need any further adjustments! |
There was a problem hiding this comment.
Hi @Andyporras, please read my review. Also use tab "Files changes" on your PR to saw a sumup of your changes.
|
In the end, you implemented the same code as in PR #451. I will accept your PR for the logs, etc. |
|
@Binnette I have already made the changes you suggested |
This pull request modifies the GPX export path to ensure files are saved in a visible and accessible location for the user. Previously, files were exported to a default location that was not accessible, making it difficult for users to locate them. With this update, GPX files are saved in the Downloads folder, improving the user experience.
Compatibility: The solution has been tested and works up to the latest version of Android 14.
Important Note: This PR depends on the approval of #457 'Updating the target SDK to 35 with the necessary changes in dependencies, permissions and execution flows'. Please make sure to approve PR #457 before proceeding with this one."
Issues solved: