fix(FR-820): compact sidebar doesn't work when refreshing.#3495
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.18% | 409/9781 |
| 🔴 | Branches | 3.55% (-0% 🔻) |
240/6767 |
| 🔴 | Functions | 2.54% | 79/3111 |
| 🔴 | Lines | 4.12% | 394/9566 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 99a2905
ironAiken2
requested changes
Apr 14, 2025
Contributor
ironAiken2
left a comment
ironAiken2
left a comment
There was a problem hiding this comment.
The collapse button doesn't work.
agatha197
force-pushed
the
fix_FR-820_/compact-sidebar-doesn_t-work
branch
from
39abc29 to
295ed39
Compare
Contributor
Author
|
fixed! |
yomybaby
force-pushed
the
fix_FR-820_/compact-sidebar-doesn_t-work
branch
from
295ed39 to
10fe1ef
Compare
Merge activity
|
resolves #3340, #3496 ([FR-820](https://lablup.atlassian.net/browse/FR-820)) ## Remove redundant `onCollapse` handler in MainLayout to keep sidebar collapse after refreshing This PR removes the redundant `onCollapse` handler from the MainLayout component. The handler was setting the `sideCollapsed` state, which is already being handled by the existing `onBreakpoint` function. ### Minimum requirements to check during review - wide screen - [ ] if compact sidebar is true, keep compact sidebar after refreshing. - [ ] if compact sidebar is false, sidebar always expanded. - middle screen - [ ] always compact sidebar - narrow screen - [ ] always hidden sidebar **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review: toggle `Use Compact Sidebar by default` in usersettings page. - [ ] Test case(s) to demonstrate the difference of before/after [FR-820]: https://lablup.atlassian.net/browse/FR-820?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
Bot
force-pushed
the
fix_FR-820_/compact-sidebar-doesn_t-work
branch
from
10fe1ef to
99a2905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3340, #3496 (FR-820)
Remove redundant
onCollapsehandler in MainLayout to keep sidebar collapse after refreshingThis PR removes the redundant
onCollapsehandler from the MainLayout component. The handler was setting thesideCollapsedstate, which is already being handled by the existingonBreakpointfunction.Minimum requirements to check during review
Checklist:
Use Compact Sidebar by defaultin usersettings page.