-
Notifications
You must be signed in to change notification settings - Fork 79
feat(FR-2665): rename sidebar menu Serving → Deployments #6905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,7 +85,7 @@ export const VALID_MENU_KEYS = [ | |
| 'summary', // alias to dashboard for backward compatibility | ||
| 'session', | ||
| 'job', // alias to session for backward compatibility | ||
| 'serving', | ||
| 'deployments', | ||
| 'model-store', | ||
| 'ai-agent', | ||
| 'chat', | ||
|
|
@@ -101,7 +101,7 @@ export const VALID_MENU_KEYS = [ | |
| 'scheduler', | ||
| 'resource-policy', | ||
| 'reservoir', | ||
| 'admin-serving', | ||
| 'admin-deployments', | ||
| 'admin-dashboard', | ||
| 'admin-data', | ||
| 'project-admin-users', | ||
|
|
@@ -126,7 +126,7 @@ const ALL_ADMIN_PAGE_KEYS: ReadonlySet<string> = new Set([ | |
| 'scheduler', | ||
| 'resource-policy', | ||
| 'reservoir', | ||
| 'admin-serving', | ||
| 'admin-deployments', | ||
| 'admin-dashboard', | ||
| 'admin-data', | ||
| 'project-admin-users', | ||
|
|
@@ -141,13 +141,13 @@ const ALL_ADMIN_PAGE_KEYS: ReadonlySet<string> = new Set([ | |
| ]); | ||
|
|
||
| // Admin-category page keys reachable by a project admin (3-tier admin gating). | ||
| // Project admins see Sessions, Serving, Data (vfolders) and Members within the | ||
| // admin category. Other admin pages remain visible only to domain admins or | ||
| // Project admins see Sessions, Deployments, Data (vfolders) and Members within | ||
| // the admin category. Other admin pages remain visible only to domain admins or | ||
| // superadmins. Kept as a plain array so it can be exported and reused (e.g. for | ||
| // per-page route gating in follow-up PRs). | ||
| export const PROJECT_ADMIN_PAGE_KEYS = [ | ||
| // 'admin-session', | ||
| // 'admin-serving', | ||
| // 'admin-deployments', | ||
| // 'admin-data', | ||
| 'project-admin-users', | ||
| ] as const; | ||
|
|
@@ -158,7 +158,7 @@ const PROJECT_ADMIN_PAGE_KEY_SET: ReadonlySet<string> = new Set( | |
|
|
||
| // Page keys that additionally require superadmin role | ||
| const SUPERADMIN_ONLY_PAGE_KEYS: ReadonlySet<string> = new Set([ | ||
| 'admin-serving', | ||
| 'admin-deployments', | ||
| 'admin-dashboard', | ||
| 'admin-data', | ||
| 'agent', | ||
|
|
@@ -268,10 +268,10 @@ export const useWebUIMenuItems = (props?: UseWebUIMenuItemsProps) => { | |
| 'workload', | ||
| ), | ||
| createMenuItem( | ||
| '/serving', | ||
| t('webui.menu.Serving'), | ||
| '/deployments', | ||
| t('webui.menu.Deployments'), | ||
| <BAIEndpointsIcon style={{ color: token.colorPrimary }} />, | ||
| 'serving', | ||
| 'deployments', | ||
| 'service', | ||
| ), | ||
| createMenuItem( | ||
|
|
@@ -379,10 +379,12 @@ export const useWebUIMenuItems = (props?: UseWebUIMenuItemsProps) => { | |
| }, | ||
| isSuperAdmin && { | ||
| label: ( | ||
| <WebUILink to="/admin-serving">{t('webui.menu.Serving')}</WebUILink> | ||
| <WebUILink to="/admin-deployments"> | ||
| {t('webui.menu.Deployments')} | ||
| </WebUILink> | ||
| ), | ||
| icon: <BAIEndpointsIcon style={{ color: token.colorInfo }} />, | ||
| key: 'admin-serving' as MenuKeys, | ||
| key: 'admin-deployments' as MenuKeys, | ||
| group: 'admin-operations' as AdminMenuGroupName, | ||
| }, | ||
|
Comment on lines
381
to
389
|
||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the main menu item route from
/servingto/deploymentsand the key fromservingtodeployments, but the app routing and many in-app links still point to/serving(e.g.react/src/routes.tsxdefinespath: '/serving'and several components navigate to/serving/...). As-is, clicking this sidebar item will navigate to a route that doesn't exist. Either keep the path/key as/serving/servingand only change the displayed label to “Deployments”, or updateroutes.tsxand all/servingnavigations (ideally with redirects for backward compatibility).