feat(FR-2665): rename sidebar menu Serving → Deployments#6905
Conversation
github-actions
Bot
added
area:ux
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.59% | 1757/20465 |
| 🔴 | Branches | 7.89% | 1131/14338 |
| 🔴 | Functions | 5.13% | 285/5557 |
| 🔴 | Lines | 8.3% | 1649/19860 |
Test suite run success
856 tests passing in 39 suites.
Report generated by 🧪jest coverage report action from 39bdb03
There was a problem hiding this comment.
Pull request overview
Renames the WebUI sidebar menu item “Serving” to “Deployments” by introducing a new i18n key and updating menu keys/paths used by the menu and Start page.
Changes:
- Added
webui.menu.Deploymentsto English translations. - Renamed menu keys from
serving→deploymentsandadmin-serving→admin-deploymentsinuseWebUIMenuItems, including updating the menu routes to/deploymentsand/admin-deployments. - Updated Start page board gating key from
servingtodeployments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
resources/i18n/en.json |
Adds the new “Deployments” menu label key (English only). |
react/src/pages/StartPage.tsx |
Updates requiredMenuKey for the model service tile to the renamed key. |
react/src/hooks/useWebUIMenuItems.tsx |
Renames menu keys and changes menu navigation paths to /deployments and /admin-deployments. |
| "Data": "Data", | ||
| "Data&Model": "Data & Model", | ||
| "Data&Storage": "Data & Storage", | ||
| "Deployments": "Deployments", |
There was a problem hiding this comment.
Added a new webui.menu.Deployments entry only in en.json. Other locale files still only define webui.menu.Serving, so switching the menu label to t('webui.menu.Deployments') will show a missing-translation fallback for non-English locales. Please add the same Deployments key to all supported locale JSON files (or rename/reuse an existing key consistently across locales).
| "Deployments": "Deployments", | |
| "Serving": "Deployments", |
| '/deployments', | ||
| t('webui.menu.Deployments'), | ||
| <BAIEndpointsIcon style={{ color: token.colorPrimary }} />, | ||
| 'serving', | ||
| 'deployments', | ||
| 'service', | ||
| ), |
There was a problem hiding this comment.
This changes the main menu item route from /serving to /deployments and the key from serving to deployments, but the app routing and many in-app links still point to /serving (e.g. react/src/routes.tsx defines path: '/serving' and several components navigate to /serving/...). As-is, clicking this sidebar item will navigate to a route that doesn't exist. Either keep the path/key as /serving/serving and only change the displayed label to “Deployments”, or update routes.tsx and all /serving navigations (ideally with redirects for backward compatibility).
| label: ( | ||
| <WebUILink to="/admin-serving">{t('webui.menu.Serving')}</WebUILink> | ||
| <WebUILink to="/admin-deployments"> | ||
| {t('webui.menu.Deployments')} | ||
| </WebUILink> | ||
| ), | ||
| icon: <BAIEndpointsIcon style={{ color: token.colorInfo }} />, | ||
| key: 'admin-serving' as MenuKeys, | ||
| key: 'admin-deployments' as MenuKeys, | ||
| group: 'admin-operations' as AdminMenuGroupName, | ||
| }, |
There was a problem hiding this comment.
The admin menu link/key was changed to /admin-deployments + admin-deployments, but routing still registers /admin-serving (see react/src/routes.tsx) and related pages/components still reference /admin-serving. This will make the admin menu item lead to a 404. Please update the router and all /admin-serving references (and consider a redirect), or keep the existing /admin-serving path/key and only rename the label.
| export const VALID_MENU_KEYS = [ | ||
| // generalMenu keys | ||
| 'start', | ||
| 'dashboard', | ||
| 'summary', // alias to dashboard for backward compatibility | ||
| 'session', | ||
| 'job', // alias to session for backward compatibility | ||
| 'serving', | ||
| 'deployments', | ||
| 'model-store', | ||
| 'ai-agent', | ||
| 'chat', | ||
| 'data', | ||
| 'my-environment', | ||
| 'agent-summary', | ||
| 'statistics', | ||
| 'pipeline', | ||
| // adminMenu keys | ||
| 'admin-session', | ||
| 'credential', | ||
| 'environment', | ||
| 'scheduler', | ||
| 'resource-policy', | ||
| 'reservoir', | ||
| 'admin-serving', | ||
| 'admin-deployments', | ||
| 'admin-dashboard', | ||
| 'admin-data', |
There was a problem hiding this comment.
VALID_MENU_KEYS drops serving/admin-serving entirely, but there are still many code paths and routes using those keys/paths (e.g. /serving and /admin-serving in react/src/routes.tsx, and navigations in components). Beyond navigation, this list is also used for webserver config diagnostics (useWebServerConfigDiagnostics), so existing blockList/inactiveList configs containing serving will start being flagged as invalid. Consider keeping serving/admin-serving as backward-compatible aliases (similar to summary/job) and mapping them to the new Deployments page, or complete the rename across router/config validation in the same PR.
agatha197
force-pushed
the
04-22-feat_fr-2665_rename_sidebar_menu_serving_deployments
branch
from
f729cbb to
39bdb03
Compare
agatha197
changed the base branch from
graphite-base/6905
to
04-22-feat_fr-2664_add__deployments__admin-deployments_routes_with_legacy_fallbacks
|
Consolidated into grouped PR stack (Foundation/Components/Launcher/List/Detail). Closing this individual PR. |
resolves #NNN (FR-MMM)
Checklist: (if applicable)