Skip to content

feat(FR-2833): show deployment ID and use BooleanTag for public access#7285

Merged
yomybaby merged 2 commits into
mainfrom
05-07-feat_fr-2833_show_deployment_id_and_use_booleantag_for_public_access
May 7, 2026
Merged

feat(FR-2833): show deployment ID and use BooleanTag for public access#7285
yomybaby merged 2 commits into
mainfrom
05-07-feat_fr-2833_show_deployment_id_and_use_booleantag_for_public_access

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 7, 2026

Resolves #7284 (FR-2833)

Summary

  • Display the deployment ID via BAIId (decoded local UUID) next to the deployment name in the overview, with the name shown via copyable BAIText.
  • Replace CheckOutlined/CloseOutlined icons with BooleanTag for the OpenToPublic field, with localized Yes/No labels and a - fallback when the value is missing.
  • Reorder overview fields so DesiredReplicas appears before Tags, matching the modal order.
  • In DeploymentSettingModal, reorder fields (Name → Replicas → Tags → OpenToPublic) and give the OpenToPublic form item a proper label with a localized "Public" checkbox text.
  • Add general.ID, deployment.Public, and deployment.NameAndID i18n keys across all 22 supported languages (single combined key replaces concatenated label).

Test plan

  • Open a deployment detail page; verify the overview shows the deployment name (copyable) followed by its ID.
  • Verify OpenToPublic renders as a localized BooleanTag (Yes/No) instead of an icon, and shows - while loading.
  • Verify field order in the overview: Name (ID) → Project → Domain → EndpointUrl → OpenToPublic → DesiredReplicas → Tags.
  • Open the deployment Setting modal; verify field order: Name → Replicas → Tags → OpenToPublic with a "Public" label/checkbox.
  • Verify all new i18n keys render in English and Korean (and at least one other language).

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels May 7, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented May 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.51% 1783 / 27379
🔵 Statements 5.38% 1978 / 36740
🔵 Functions 5.19% 296 / 5696
🔵 Branches 3.78% 1293 / 34204
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/components/DeploymentConfigurationSection.tsx 0% 0% 0% 0% 54-356
react/src/components/DeploymentSettingModal.tsx 0% 0% 0% 0% 44-223
Generated in workflow #434 for commit 43b2147 by the Vitest Coverage Report Action

@yomybaby yomybaby marked this pull request as ready for review May 7, 2026 09:57
Copilot AI review requested due to automatic review settings May 7, 2026 09:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deployment detail UI to surface an ID next to the deployment name, replace the OpenToPublic icon indicator with a BooleanTag, and align field ordering between the overview and the settings modal. It also adds i18n entries needed for the new label/checkbox text.

Changes:

  • Deployment overview: show deployment name as copyable text and display an ID next to it; reorder overview items so DesiredReplicas appears before Tags.
  • OpenToPublic indicator: replace check/close icons with BooleanTag.
  • Deployment settings modal: reorder fields (Name → Replicas → Tags → OpenToPublic) and add a labeled OpenToPublic checkbox using new i18n keys.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
react/src/components/DeploymentConfigurationSection.tsx Adds ID display next to name, switches OpenToPublic to BooleanTag, reorders overview fields, and fetches deployment id.
react/src/components/DeploymentSettingModal.tsx Reorders form items and adds a labeled OpenToPublic checkbox with localized “Public” text.
resources/i18n/en.json Adds deployment.Public and general.ID strings.
resources/i18n/ko.json Adds deployment.Public and general.ID strings.
resources/i18n/de.json Adds deployment.Public and general.ID strings.
resources/i18n/el.json Adds deployment.Public and general.ID strings.
resources/i18n/es.json Adds deployment.Public and general.ID strings.
resources/i18n/fi.json Adds deployment.Public and general.ID strings.
resources/i18n/fr.json Adds deployment.Public and general.ID strings.
resources/i18n/id.json Adds deployment.Public and general.ID strings.
resources/i18n/it.json Adds deployment.Public and general.ID strings.
resources/i18n/ja.json Adds deployment.Public and general.ID strings.
resources/i18n/mn.json Adds deployment.Public and general.ID strings.
resources/i18n/ms.json Adds deployment.Public and general.ID strings.
resources/i18n/pl.json Adds deployment.Public and general.ID strings.
resources/i18n/pt.json Adds deployment.Public and general.ID strings.
resources/i18n/pt-BR.json Adds deployment.Public and general.ID strings.
resources/i18n/ru.json Adds deployment.Public and general.ID strings.
resources/i18n/th.json Adds deployment.Public and general.ID strings.
resources/i18n/tr.json Adds deployment.Public and general.ID strings.
resources/i18n/vi.json Adds deployment.Public and general.ID strings.
resources/i18n/zh-CN.json Adds deployment.Public and general.ID strings.
resources/i18n/zh-TW.json Adds deployment.Public and general.ID strings.

Comment thread react/src/components/DeploymentConfigurationSection.tsx Outdated
Comment thread react/src/components/DeploymentConfigurationSection.tsx
Comment thread react/src/components/DeploymentConfigurationSection.tsx Outdated
Comment thread react/src/components/DeploymentConfigurationSection.tsx
Comment thread react/src/components/DeploymentConfigurationSection.tsx
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 7, 2026

Merge activity

graphite-app Bot pushed a commit that referenced this pull request May 7, 2026
#7285)

Resolves #7284 ([FR-2833](https://lablup.atlassian.net/browse/FR-2833))

## Summary
- Display deployment global ID via `BAIId` next to the deployment name in the overview, with the name shown via copyable `BAIText`.
- Replace `CheckOutlined`/`CloseOutlined` icons with `BooleanTag` for the OpenToPublic field for a consistent, color-coded boolean indicator.
- Reorder overview fields so DesiredReplicas appears before Tags, matching the modal order.
- In `DeploymentSettingModal`, reorder fields (Name → Replicas → Tags → OpenToPublic) and give the OpenToPublic form item a proper label with a localized "Public" checkbox text.
- Add `general.ID` and `deployment.Public` i18n keys across all 22 supported languages.

## Test plan
- [ ] Open a deployment detail page; verify the overview shows the deployment name (copyable) followed by its global ID.
- [ ] Verify OpenToPublic renders as a `BooleanTag` instead of an icon.
- [ ] Verify field order in the overview: Name (ID) → Project → Domain → EndpointUrl → OpenToPublic → DesiredReplicas → Tags.
- [ ] Open the deployment Setting modal; verify field order: Name → Replicas → Tags → OpenToPublic with a "Public" label/checkbox.
- [ ] Verify both new i18n keys render in English and Korean (and at least one other language).

[FR-2833]: https://lablup.atlassian.net/browse/FR-2833?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the 05-07-feat_fr-2833_show_deployment_id_and_use_booleantag_for_public_access branch from 787ff44 to 816b172 Compare May 7, 2026 10:04
@yomybaby yomybaby force-pushed the 05-07-feat_fr-2833_show_deployment_id_and_use_booleantag_for_public_access branch from 816b172 to 43b2147 Compare May 7, 2026 10:10
@yomybaby yomybaby merged commit 1154189 into main May 7, 2026
17 checks passed
@yomybaby yomybaby deleted the 05-07-feat_fr-2833_show_deployment_id_and_use_booleantag_for_public_access branch May 7, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show deployment ID and use BooleanTag for public access in deployment overview

2 participants