Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions react/src/components/DeploymentAddRevisionModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ interface DeploymentAddRevisionModalProps extends BAIModalProps {
type FormValues = ImageEnvironmentFormInput &
ResourceAllocationFormValue &
VFolderTableFormValues & {
name?: string;
runtimeVariantId: string;
modelFolderId: string;
mountDestination: string;
Expand Down Expand Up @@ -294,7 +293,6 @@ const DeploymentAddRevisionModalFormBody: React.FC<
addModelRevision(input: $input) {
revision {
id
name
clusterConfig {
mode
size
Expand Down Expand Up @@ -783,7 +781,6 @@ const DeploymentAddRevisionModalFormBody: React.FC<
variables: {
input: {
deploymentId: toLocalId(deploymentId) ?? deploymentId,
name: values.name || undefined,
clusterConfig: {
mode: clusterMode,
size: values.cluster_size,
Expand Down Expand Up @@ -902,9 +899,6 @@ const DeploymentAddRevisionModalFormBody: React.FC<
autoActivate: true,
})}
>
<Form.Item name="name" label={t('deployment.RevisionName')}>
<Input placeholder={t('deployment.RevisionNamePlaceholder')} />
</Form.Item>
<Form.Item name="autoActivate" valuePropName="checked">
<Checkbox>{t('deployment.AutoActivate')}</Checkbox>
</Form.Item>
Expand Down
4 changes: 1 addition & 3 deletions react/src/components/DeploymentConfigurationSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,10 @@ const DeploymentConfigurationSection: React.FC<
}
currentRevision @since(version: "26.4.3") {
id
name
...DeploymentRevisionDetail_revision
}
deployingRevision @since(version: "26.4.3") {
id
name
...DeploymentRevisionDetail_revision
}
...DeploymentRevisionHistoryTab_deployment
Expand Down Expand Up @@ -378,7 +376,7 @@ const DeploymentConfigurationSection: React.FC<
icon={<LoadingOutlined spin />}
showIcon
title={t('deployment.DeployingRevisionApplying', {
name: deployingRevision.name ?? '',
name: toLocalId(deployingRevision.id) ?? '',
})}
action={
<Button
Expand Down
6 changes: 4 additions & 2 deletions react/src/components/DeploymentReplicasTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
BAIUnmountAfterClose,
type GraphQLFilter,
filterOutEmpty,
toLocalId,
} from 'backend.ai-ui';
import dayjs from 'dayjs';
import * as _ from 'lodash-es';
Expand Down Expand Up @@ -175,7 +176,6 @@ const DeploymentReplicasTab: React.FC<DeploymentReplicasTabProps> = ({
createdAt
revision {
id
name
}
}
}
Expand Down Expand Up @@ -288,7 +288,9 @@ const DeploymentReplicasTab: React.FC<DeploymentReplicasTabProps> = ({
key: 'revision',
title: t('deployment.Revision'),
render: (_: unknown, record: ReplicaNode) =>
record.revision?.name ?? (
record.revision?.id ? (
toLocalId(record.revision.id)
) : (
<Typography.Text type="secondary">—</Typography.Text>
),
},
Expand Down
5 changes: 2 additions & 3 deletions react/src/components/DeploymentRevisionDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ const DeploymentRevisionDetail: React.FC<{
graphql`
fragment DeploymentRevisionDetail_revision on ModelRevision {
id
name
createdAt
clusterConfig {
mode
Expand Down Expand Up @@ -132,9 +131,9 @@ const DeploymentRevisionDetail: React.FC<{
{
key: 'revision-name',
label: t('modelService.RevisionID'),
children: revision.name ? (
children: revision.id ? (
<BAIFlex gap="xs" align="center">
<Typography.Text>{revision.name}</Typography.Text>
<Typography.Text>{toLocalId(revision.id)}</Typography.Text>
{status === 'current' && (
<BAITag color="success">{t('deployment.Current')}</BAITag>
)}
Expand Down
10 changes: 3 additions & 7 deletions react/src/components/DeploymentRevisionHistoryTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ const DeploymentRevisionHistoryTab: React.FC<
edges {
node {
id
name
createdAt

clusterConfig {
mode
size
Expand Down Expand Up @@ -245,7 +245,6 @@ const DeploymentRevisionHistoryTab: React.FC<
currentRevisionId
currentRevision {
id
name
}
}
previousRevisionId
Expand Down Expand Up @@ -278,10 +277,7 @@ const DeploymentRevisionHistoryTab: React.FC<
};

const handleRollback = (revision: RevisionNode): Promise<boolean> => {
// The `name` field is the human-readable revision number label
// ("#3"). Fall back to the trimmed UUID if absent so the confirm
// text is never blank.
const revisionLabel = revision.name ?? toLocalId(revision.id);
const revisionLabel = toLocalId(revision.id);
return new Promise<boolean>((resolveOuter) => {
modal.confirm({
title: t('deployment.Deploy'),
Expand Down Expand Up @@ -382,7 +378,7 @@ const DeploymentRevisionHistoryTab: React.FC<
})
}
>
{record.name ?? '-'}
{recordLocalId ?? '-'}
</Typography.Link>
{isCurrent ? (
<BAITag color="success">{t('deployment.Current')}</BAITag>
Expand Down
1 change: 0 additions & 1 deletion react/src/components/ServiceLauncherPageContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1405,7 +1405,6 @@ const ServiceLauncherPageContent: React.FC<ServiceLauncherPageContentProps> = ({
) {
edges {
node {
name
modelDefinition {
models {
service {
Expand Down
13 changes: 8 additions & 5 deletions react/src/pages/EndpointDetailPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ import {
GraphQLFilter,
SemanticColor,
toGlobalId,
toLocalId,
useFetchKey,
useSemanticColorMap,
BAITable,
Expand Down Expand Up @@ -365,7 +366,6 @@ const EndpointDetailPage: React.FC<EndpointDetailPageProps> = () => {
}
currentRevision {
id
name
modelDefinition {
models {
name
Expand All @@ -389,7 +389,6 @@ const EndpointDetailPage: React.FC<EndpointDetailPageProps> = () => {
edges {
node {
id
name
modelDefinition {
models {
name
Expand Down Expand Up @@ -807,9 +806,13 @@ const EndpointDetailPage: React.FC<EndpointDetailPageProps> = () => {
const latestRevisionItems = buildModelDefinitionItems(
modelDeployment?.revisionHistory?.edges?.[0]?.node?.modelDefinition?.models,
);
const currentRevisionName = modelDeployment?.currentRevision?.name;
const latestRevisionName =
modelDeployment?.revisionHistory?.edges?.[0]?.node?.name;
const currentRevisionName = modelDeployment?.currentRevision?.id
? toLocalId(modelDeployment.currentRevision.id)
: undefined;
const latestRevisionName = modelDeployment?.revisionHistory?.edges?.[0]?.node
?.id
? toLocalId(modelDeployment.revisionHistory.edges[0].node.id)
: undefined;
const isRevisionMismatch =
modelDeployment?.currentRevision?.id != null &&
modelDeployment?.revisionHistory?.edges?.[0]?.node?.id != null &&
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Revisionsverlauf",
"RevisionId": "Revisions-ID",
"RevisionIdPlaceholder": "Revisions-ID eingeben (optional)",
"RevisionName": "Revisionsname",
"RevisionNamePlaceholder": "Leer lassen für automatische Generierung",
"RevisionNumber": "Revisionsnummer",
"Revisions": "Revisionen",
"Running": "Läuft",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/el.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Ιστορικό Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Εισάγετε ID Revision (προαιρετικό)",
"RevisionName": "Όνομα Revision",
"RevisionNamePlaceholder": "Αφήστε κενό για αυτόματη δημιουργία",
"RevisionNumber": "Αριθμός Αναθεώρησης",
"Revisions": "Revision",
"Running": "Σε εκτέλεση",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -988,8 +988,6 @@
"RevisionHistory": "Revision History",
"RevisionId": "Revision ID",
"RevisionIdPlaceholder": "Leave blank to auto-generate",
"RevisionName": "Revision Name",
"RevisionNamePlaceholder": "Leave blank to auto-generate",
"RevisionNumber": "Revision Number",
"Revisions": "Revisions",
"Running": "Running",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Historial de Revision",
"RevisionId": "ID de Revision",
"RevisionIdPlaceholder": "Ingrese un ID de Revision (opcional)",
"RevisionName": "Nombre de Revision",
"RevisionNamePlaceholder": "Dejar en blanco para generar automáticamente",
"RevisionNumber": "Número de Revisión",
"Revisions": "Revision",
"Running": "En ejecución",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Revision-historia",
"RevisionId": "Revision ID",
"RevisionIdPlaceholder": "Anna Revision ID (valinnainen)",
"RevisionName": "Revision nimi",
"RevisionNamePlaceholder": "Jätä tyhjäksi automaattista luontia varten",
"RevisionNumber": "Revisionumero",
"Revisions": "Revision",
"Running": "Käynnissä",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Historique de Revision",
"RevisionId": "ID de Revision",
"RevisionIdPlaceholder": "Saisir un ID de Revision (facultatif)",
"RevisionName": "Nom de Revision",
"RevisionNamePlaceholder": "Laisser vide pour génération automatique",
"RevisionNumber": "Numéro de Revision",
"Revisions": "Revision",
"Running": "En cours d'exécution",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/id.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Riwayat Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Masukkan ID Revision (opsional)",
"RevisionName": "Nama Revision",
"RevisionNamePlaceholder": "Biarkan kosong untuk dibuat otomatis",
"RevisionNumber": "Nomor Revisi",
"Revisions": "Revision",
"Running": "Berjalan",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Cronologia Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Inserisci un ID Revision (opzionale)",
"RevisionName": "Nome Revision",
"RevisionNamePlaceholder": "Lascia vuoto per la generazione automatica",
"RevisionNumber": "Numero di Revisione",
"Revisions": "Revision",
"Running": "In esecuzione",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Revision 履歴",
"RevisionId": "Revision ID",
"RevisionIdPlaceholder": "Revision ID を入力(任意)",
"RevisionName": "Revision 名",
"RevisionNamePlaceholder": "空白のままにすると自動生成されます",
"RevisionNumber": "Revision 番号",
"Revisions": "Revision",
"Running": "実行中",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -987,8 +987,6 @@
"RevisionHistory": "리비전 히스토리",
"RevisionId": "리비전 ID",
"RevisionIdPlaceholder": "리비전 ID를 입력하세요 (선택 사항)",
"RevisionName": "리비전 이름",
"RevisionNamePlaceholder": "비워두면 자동 생성",
"RevisionNumber": "리비전 번호",
"Revisions": "리비전",
"Running": "실행 중",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/mn.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Revision-ы түүх",
"RevisionId": "Revision ID",
"RevisionIdPlaceholder": "Revision ID оруулна уу (заавал биш)",
"RevisionName": "Revision нэр",
"RevisionNamePlaceholder": "Автоматаар үүсгэхийн тулд хоосон үлдээнэ үү",
"RevisionNumber": "Revision дугаар",
"Revisions": "Revision-ууд",
"Running": "Ажиллаж байна",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/ms.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Sejarah Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Masukkan ID Revision (pilihan)",
"RevisionName": "Nama Revision",
"RevisionNamePlaceholder": "Biarkan kosong untuk jana secara automatik",
"RevisionNumber": "Nombor Revisi",
"Revisions": "Revision",
"Running": "Sedang berjalan",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Historia Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Wprowadź ID Revision (opcjonalne)",
"RevisionName": "Nazwa Revision",
"RevisionNamePlaceholder": "Pozostaw puste, aby wygenerować automatycznie",
"RevisionNumber": "Numer Rewizji",
"Revisions": "Revision",
"Running": "Uruchomiony",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Histórico de Revision",
"RevisionId": "ID de Revision",
"RevisionIdPlaceholder": "Insira um ID de Revision (opcional)",
"RevisionName": "Nome da Revision",
"RevisionNamePlaceholder": "Deixe em branco para gerar automaticamente",
"RevisionNumber": "Número de Revisão",
"Revisions": "Revision",
"Running": "Em execução",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Histórico de Revision",
"RevisionId": "ID de Revision",
"RevisionIdPlaceholder": "Introduza um ID de Revision (opcional)",
"RevisionName": "Nome da Revision",
"RevisionNamePlaceholder": "Deixe em branco para geração automática",
"RevisionNumber": "Número de Revisão",
"Revisions": "Revision",
"Running": "Em execução",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "История Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Введите ID Revision (необязательно)",
"RevisionName": "Название Revision",
"RevisionNamePlaceholder": "Оставьте пустым для автоматической генерации",
"RevisionNumber": "Номер ревизии",
"Revisions": "Revision",
"Running": "Выполняется",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/th.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "ประวัติ Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "กรอก ID Revision (ไม่บังคับ)",
"RevisionName": "ชื่อ Revision",
"RevisionNamePlaceholder": "ปล่อยว่างเพื่อสร้างอัตโนมัติ",
"RevisionNumber": "หมายเลข Revision",
"Revisions": "Revision",
"Running": "กำลังทำงาน",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/tr.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Revision Geçmişi",
"RevisionId": "Revision Kimliği",
"RevisionIdPlaceholder": "Bir Revision Kimliği girin (isteğe bağlı)",
"RevisionName": "Revision Adı",
"RevisionNamePlaceholder": "Otomatik oluşturmak için boş bırakın",
"RevisionNumber": "Revizyon Numarası",
"Revisions": "Revision",
"Running": "Çalışıyor",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Lịch sử Revision",
"RevisionId": "ID Revision",
"RevisionIdPlaceholder": "Nhập ID Revision (tùy chọn)",
"RevisionName": "Tên Revision",
"RevisionNamePlaceholder": "Để trống để tự động tạo",
"RevisionNumber": "Số Revision",
"Revisions": "Revision",
"Running": "Đang chạy",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,6 @@
"RevisionHistory": "Revision 历史",
"RevisionId": "Revision ID",
"RevisionIdPlaceholder": "输入 Revision ID(可选)",
"RevisionName": "Revision 名称",
"RevisionNamePlaceholder": "留空以自动生成",
"RevisionNumber": "Revision 编号",
"Revisions": "Revision",
"Running": "运行中",
Expand Down
2 changes: 0 additions & 2 deletions resources/i18n/zh-TW.json
Original file line number Diff line number Diff line change
Expand Up @@ -987,8 +987,6 @@
"RevisionHistory": "Revision 歷史",
"RevisionId": "Revision ID",
"RevisionIdPlaceholder": "輸入 Revision ID(選填)",
"RevisionName": "Revision 名稱",
"RevisionNamePlaceholder": "留空以自動生成",
"RevisionNumber": "Revision 編號",
"Revisions": "Revision",
"Running": "執行中",
Expand Down
Loading