Skip to content

fix(FR-2836): remove unused revision name field from Add Revision modal#7291

Merged
graphite-app[bot] merged 1 commit into
mainfrom
fix/FR-2836-remove-revision-name-field
May 8, 2026
Merged

fix(FR-2836): remove unused revision name field from Add Revision modal#7291
graphite-app[bot] merged 1 commit into
mainfrom
fix/FR-2836-remove-revision-name-field

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented May 8, 2026

Resolves #7290 (FR-2836)

Stacked on top of #7289

Summary

  • Remove the unused Revision Name text input from the Add Revision modal.
  • Drop name from the FormValues type and from the addModelRevision mutation payload.
  • Delete the now-unused i18n keys deployment.RevisionName and deployment.RevisionNamePlaceholder across all 21 supported locales.

Test plan

  • Open the deployment page and click Add Revision.
  • Verify the Revision Name input is no longer present.
  • Submit the modal — the new revision is created without sending a name to the backend.
  • Confirm no missing-i18n-key warnings appear in the dev console.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:M 30~100 LoC labels May 8, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented May 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 marked this pull request as ready for review May 8, 2026 01:07
@agatha197 agatha197 requested review from Copilot and yomybaby and removed request for Copilot May 8, 2026 01:07
@agatha197 agatha197 changed the base branch from feat/FR-2835-add-auto-activate-option to graphite-base/7291 May 8, 2026 02:04
Copilot AI review requested due to automatic review settings May 8, 2026 02:04
@agatha197 agatha197 force-pushed the fix/FR-2836-remove-revision-name-field branch from 28899a8 to 1dad518 Compare May 8, 2026 02:04
@agatha197 agatha197 force-pushed the graphite-base/7291 branch from 56c7a2e to 73e58ea Compare May 8, 2026 02:04
@agatha197 agatha197 changed the base branch from graphite-base/7291 to feat/FR-2835-add-auto-activate-option May 8, 2026 02:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused “Revision Name” field from the Add Revision modal and cleans up associated frontend plumbing (form typing, mutation payload, and i18n keys) to avoid sending an ignored name value to the backend.

Changes:

  • Removed the Revision Name form item from DeploymentAddRevisionModal and dropped name from the form value type and mutation variables.
  • Deleted unused i18n keys deployment.RevisionName and deployment.RevisionNamePlaceholder.
  • Removed the corresponding translations across all supported resources/i18n/*.json locale files.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
react/src/components/DeploymentAddRevisionModal.tsx Removes the Revision Name input and stops sending name in the addModelRevision mutation payload.
resources/i18n/en.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/de.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/el.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/es.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/fi.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/fr.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/id.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/it.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/ja.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/ko.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/mn.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/ms.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/pl.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/pt.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/pt-BR.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/ru.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/th.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/tr.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/vi.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/zh-CN.json Removes unused deployment.RevisionName* translation keys.
resources/i18n/zh-TW.json Removes unused deployment.RevisionName* translation keys.

Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the fix/FR-2836-remove-revision-name-field branch from 1dad518 to af491a6 Compare May 8, 2026 09:30
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 8, 2026

Merge activity

@graphite-app graphite-app Bot changed the base branch from feat/FR-2835-add-auto-activate-option to graphite-base/7291 May 8, 2026 09:32
@yomybaby yomybaby force-pushed the graphite-base/7291 branch from 73e58ea to 316c42a Compare May 8, 2026 09:48
@yomybaby yomybaby force-pushed the fix/FR-2836-remove-revision-name-field branch from af491a6 to 71dfa8d Compare May 8, 2026 09:48
@yomybaby yomybaby changed the base branch from graphite-base/7291 to main May 8, 2026 09:49
@yomybaby yomybaby force-pushed the fix/FR-2836-remove-revision-name-field branch from 71dfa8d to 4e858ab Compare May 8, 2026 09:50
…al (#7291)

Resolves #7290 ([FR-2836](https://lablup.atlassian.net/browse/FR-2836))

> Stacked on top of #7289

## Summary
- Remove the unused `Revision Name` text input from the `Add Revision` modal.
- Drop `name` from the `FormValues` type and from the `addModelRevision` mutation payload.
- Delete the now-unused i18n keys `deployment.RevisionName` and `deployment.RevisionNamePlaceholder` across all 21 supported locales.

## Test plan
- [ ] Open the deployment page and click `Add Revision`.
- [ ] Verify the `Revision Name` input is no longer present.
- [ ] Submit the modal — the new revision is created without sending a `name` to the backend.
- [ ] Confirm no missing-i18n-key warnings appear in the dev console.

[FR-2836]: https://lablup.atlassian.net/browse/FR-2836?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the fix/FR-2836-remove-revision-name-field branch from 4e858ab to a14943a Compare May 8, 2026 09:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.5% 1783 / 27402
🔵 Statements 5.37% 1978 / 36784
🔵 Functions 5.19% 296 / 5699
🔵 Branches 3.77% 1293 / 34255
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/components/DeploymentAddRevisionModal.tsx 0% 0% 0% 0% 88-1194
react/src/components/DeploymentConfigurationSection.tsx 0% 0% 0% 0% 72-300
react/src/components/DeploymentReplicasTab.tsx 0% 0% 0% 0% 40-368
react/src/components/DeploymentRevisionDetail.tsx 0% 0% 0% 0% 26-297
react/src/components/DeploymentRevisionHistoryTab.tsx 0% 0% 0% 0% 59-580
react/src/components/ServiceLauncherPageContent.tsx 0% 0% 0% 0% 121-2198
react/src/pages/EndpointDetailPage.tsx 0% 0% 0% 0% 129-1605
Generated in workflow #483 for commit a14943a by the Vitest Coverage Report Action

@graphite-app graphite-app Bot merged commit a14943a into main May 8, 2026
11 checks passed
@graphite-app graphite-app Bot deleted the fix/FR-2836-remove-revision-name-field branch May 8, 2026 09:52
@github-pages github-pages Bot temporarily deployed to github-pages May 8, 2026 09:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused revision name field from Add Revision modal

3 participants