feat(FR-2838): show private-deployment alert with access-token shortcut on deployment detail by yomybaby · Pull Request #7294 · lablup/backend.ai-webui

yomybaby · 2026-05-08T02:11:51Z

Resolves #7293 (FR-2838)

Stacked on #7287 (FR-2834).

Summary

Show an info Alert on the deployment detail page when the deployment is private (openToPublic === false) and not destroying. The alert names the state and offers a "Manage Access Tokens" action that smooth-scrolls to the access tokens section (#deployment-access-tokens).
Lifted all deployment-level alerts (DeploymentReady, NoCurrentRevisionDeployed, PrivateDeployment) and the DeploymentAddRevisionModal from DeploymentConfigurationCards up to DeploymentDetailPage so they live where they semantically belong (page-wide notifications, not tied to the configuration cards).
Lifted the page-level fetchKey / revisionFetchKey / refresh transition state to DeploymentDetailPage. DeploymentConfigurationSection now receives them via props and exposes onAddRevision for both the alert and the section's own "Add Revision" tab-bar button.
Added new i18n keys (deployment.PrivateDeploymentAlertTitle, deployment.PrivateDeploymentAlertDescription, deployment.ManageAccessTokens) across all 22 supported languages.

Test plan

On a public deployment detail page, verify no private alert is shown.
On a private (openToPublic = false) deployment, verify the info alert appears with the expected title and description.
Click "Manage Access Tokens" and verify the page scrolls smoothly to the access tokens section.
Verify alert ordering is: DeploymentReady → NoCurrentRevisionDeployed → PrivateDeployment.
Verify the existing "Add Revision" tab-bar button in the configuration section still opens the AddRevision modal (now hosted by the page).
Verify the refresh button in the configuration overview still works and propagates the loading state.
On a destroying/stopped deployment, verify the private alert is suppressed.
Spot-check at least Korean, Japanese, and one Latin-script locale to confirm new keys are translated.

yomybaby · 2026-05-08T02:12:05Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Adds a page-level “private deployment” notification to the Deployment Detail page (with a shortcut to the Access Tokens section), while refactoring deployment-level alerts and the “Add Revision” modal/refresh state so they live at the page scope instead of inside the configuration cards.

Changes:

Show an info alert when a deployment is private (openToPublic === false) and not destroying, including a “Manage Access Tokens” action that smooth-scrolls to #deployment-access-tokens.
Lift deployment-level alerts and the add-revision modal / refetch keys up to DeploymentDetailPage, passing the necessary refetch/add-revision handlers down into DeploymentConfigurationSection.
Add i18n strings for the new private-deployment alert title/description and the “Manage Access Tokens” action across supported locales.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
react/src/pages/DeploymentDetailPage.tsx	Adds private-deployment alert + smooth-scroll action, and hosts page-level alerts/modals/refetch state.
react/src/components/DeploymentConfigurationSection.tsx	Refactors to accept fetch keys/refetch/add-revision callbacks from the page instead of owning them locally.
resources/i18n/en.json	Adds new deployment alert/action strings.
resources/i18n/de.json	Adds new deployment alert/action strings.
resources/i18n/el.json	Adds new deployment alert/action strings.
resources/i18n/es.json	Adds new deployment alert/action strings.
resources/i18n/fi.json	Adds new deployment alert/action strings.
resources/i18n/fr.json	Adds new deployment alert/action strings.
resources/i18n/id.json	Adds new deployment alert/action strings.
resources/i18n/it.json	Adds new deployment alert/action strings.
resources/i18n/ja.json	Adds new deployment alert/action strings.
resources/i18n/ko.json	Adds new deployment alert/action strings.
resources/i18n/mn.json	Adds new deployment alert/action strings.
resources/i18n/ms.json	Adds new deployment alert/action strings.
resources/i18n/pl.json	Adds new deployment alert/action strings.
resources/i18n/pt.json	Adds new deployment alert/action strings.
resources/i18n/pt-BR.json	Adds new deployment alert/action strings.
resources/i18n/ru.json	Adds new deployment alert/action strings.
resources/i18n/th.json	Adds new deployment alert/action strings.
resources/i18n/tr.json	Adds new deployment alert/action strings.
resources/i18n/vi.json	Adds new deployment alert/action strings.
resources/i18n/zh-CN.json	Adds new deployment alert/action strings.
resources/i18n/zh-TW.json	Adds new deployment alert/action strings.

graphite-app · 2026-05-08T02:51:38Z

Merge activity

May 8, 2:51 AM UTC: yomybaby added this pull request to the Graphite merge queue.
May 8, 2:55 AM UTC: Merged by the Graphite merge queue.

…ut on deployment detail (#7294) Resolves #7293 ([FR-2838](https://lablup.atlassian.net/browse/FR-2838)) > Stacked on #7287 (FR-2834). <img width="1231" height="601" alt="image" src="https://github.com/user-attachments/assets/b59e6692-6a8d-4b4e-95ff-3d3852c4db6d" /> ## Summary - Show an info `Alert` on the deployment detail page when the deployment is private (`openToPublic === false`) and not destroying. The alert names the state and offers a "Manage Access Tokens" action that smooth-scrolls to the access tokens section (`#deployment-access-tokens`). - Lifted all deployment-level alerts (`DeploymentReady`, `NoCurrentRevisionDeployed`, `PrivateDeployment`) and the `DeploymentAddRevisionModal` from `DeploymentConfigurationCards` up to `DeploymentDetailPage` so they live where they semantically belong (page-wide notifications, not tied to the configuration cards). - Lifted the page-level `fetchKey` / `revisionFetchKey` / refresh transition state to `DeploymentDetailPage`. `DeploymentConfigurationSection` now receives them via props and exposes `onAddRevision` for both the alert and the section's own "Add Revision" tab-bar button. - Added new i18n keys (`deployment.PrivateDeploymentAlertTitle`, `deployment.PrivateDeploymentAlertDescription`, `deployment.ManageAccessTokens`) across all 22 supported languages. ## Test plan - [ ] On a public deployment detail page, verify no private alert is shown. - [ ] On a private (`openToPublic = false`) deployment, verify the info alert appears with the expected title and description. - [ ] Click "Manage Access Tokens" and verify the page scrolls smoothly to the access tokens section. - [ ] Verify alert ordering is: DeploymentReady → NoCurrentRevisionDeployed → PrivateDeployment. - [ ] Verify the existing "Add Revision" tab-bar button in the configuration section still opens the AddRevision modal (now hosted by the page). - [ ] Verify the refresh button in the configuration overview still works and propagates the loading state. - [ ] On a destroying/stopped deployment, verify the private alert is suppressed. - [ ] Spot-check at least Korean, Japanese, and one Latin-script locale to confirm new keys are translated. [FR-2838]: https://lablup.atlassian.net/browse/FR-2838?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions · 2026-05-08T02:55:30Z

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	6.51%	1783 / 27381
🔵	Statements	5.38%	1978 / 36737
🔵	Functions	5.19%	296 / 5695
🔵	Branches	3.77%	1293 / 34211

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
react/src/components/DeploymentConfigurationSection.tsx	0%	0%	0%	0%	54-341
react/src/pages/DeploymentDetailPage.tsx	0%	0%	0%	0%	33-125

Generated in workflow #450 for commit d5f78df by the Vitest Coverage Report Action

github-actions Bot assigned yomybaby May 8, 2026

github-actions Bot added area:ux UI / UX issue. area:i18n Localization labels May 8, 2026

yomybaby mentioned this pull request May 8, 2026

feat(FR-2834): use Visibility row label with Public/Private tag for deployment OpenToPublic #7287

Merged

4 tasks

github-actions Bot added size:L 100~500 LoC size:M 30~100 LoC and removed size:L 100~500 LoC size:M 30~100 LoC labels May 8, 2026

yomybaby marked this pull request as ready for review May 8, 2026 02:43

Copilot AI review requested due to automatic review settings May 8, 2026 02:43

Copilot started reviewing on behalf of yomybaby May 8, 2026 02:44 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread react/src/pages/DeploymentDetailPage.tsx

graphite-app Bot force-pushed the 05-07-feat_fr-2834_use_visibility_row_label_with_public_private_tag_for_deployment_opentopublic branch from 8a5a711 to 18d3fe9 Compare May 8, 2026 02:52

graphite-app Bot force-pushed the 05-08-feat_fr-2838_show_private-deployment_alert_with_access-token_shortcut_on_deployment_detail branch from c0edb01 to d5f78df Compare May 8, 2026 02:52

Base automatically changed from 05-07-feat_fr-2834_use_visibility_row_label_with_public_private_tag_for_deployment_opentopublic to main May 8, 2026 02:54

graphite-app Bot merged commit d5f78df into main May 8, 2026
8 checks passed

graphite-app Bot deleted the 05-08-feat_fr-2838_show_private-deployment_alert_with_access-token_shortcut_on_deployment_detail branch May 8, 2026 02:55

github-pages Bot temporarily deployed to github-pages May 8, 2026 02:56 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2838): show private-deployment alert with access-token shortcut on deployment detail#7294

feat(FR-2838): show private-deployment alert with access-token shortcut on deployment detail#7294
graphite-app[bot] merged 1 commit into
mainfrom
05-08-feat_fr-2838_show_private-deployment_alert_with_access-token_shortcut_on_deployment_detail

yomybaby commented May 8, 2026 •

edited

Loading

Uh oh!

yomybaby commented May 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app Bot commented May 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yomybaby commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

yomybaby commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026

Coverage Report for react-coverage (./react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yomybaby commented May 8, 2026 •

edited

Loading

yomybaby commented May 8, 2026 •

edited

Loading

graphite-app Bot commented May 8, 2026 •

edited

Loading