Skip to content

feat(FR-2843): title-only deployment alerts and warning type for NoRevision#7304

Merged
yomybaby merged 2 commits into
mainfrom
05-08-feat_fr-2843_make_norevision_and_private_alerts_title-only_and_use_warning_type_for_norevision
May 8, 2026
Merged

feat(FR-2843): title-only deployment alerts and warning type for NoRevision#7304
yomybaby merged 2 commits into
mainfrom
05-08-feat_fr-2843_make_norevision_and_private_alerts_title-only_and_use_warning_type_for_norevision

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 8, 2026

Resolves #7302 (FR-2843)

Summary

  • Drop the description prop from both deployment-detail alerts (NoCurrentRevisionDeployed, PrivateDeployment) and roll the previous description content into the title text so the alerts read as a single concise line.
  • Switch NoCurrentRevisionDeployed from type="info" to type="warning" — there is no active service to serve until a revision is added, which is closer to a warning state than a neutral notice.
  • Removed the now-orphaned i18n keys deployment.NoCurrentRevisionDeployedDescription and deployment.PrivateDeploymentAlertDescription across all 22 supported languages.
  • Updated deployment.NoCurrentRevisionDeployed and deployment.PrivateDeploymentAlertTitle translations to incorporate the previous description meaning (e.g. en: 'No revision is deployed — add a revision to activate this service.').

Note: deployment.NoCurrentRevisionDeployed is also used as the <Empty> placeholder description in DeploymentConfigurationSection's "Current Revision" tab; the enriched message reads naturally there too.

Test plan

  • On a private deployment without revisions, both alerts show as a single-line title (no separate description block).
  • NoCurrentRevisionDeployed alert renders in the warning style (yellow) instead of info (blue).
  • PrivateDeployment alert remains info-style.
  • The "Current Revision" tab's <Empty> placeholder shows the same enriched message — verify it still reads well there.
  • Spot-check Korean, Japanese, and one Latin-script locale to confirm both keys are translated.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels May 8, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented May 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby changed the title feat(FR-2843): make NoRevision and Private alerts title-only and use warning type for NoRevision feat(FR-2843): title-only deployment alerts and warning type for NoRevision May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.51% 1783 / 27381
🔵 Statements 5.38% 1978 / 36737
🔵 Functions 5.19% 296 / 5695
🔵 Branches 3.77% 1293 / 34211
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/pages/DeploymentDetailPage.tsx 0% 0% 0% 0% 33-125
Generated in workflow #453 for commit 392b0fc by the Vitest Coverage Report Action

@yomybaby yomybaby marked this pull request as ready for review May 8, 2026 04:45
Copilot AI review requested due to automatic review settings May 8, 2026 04:45
@yomybaby yomybaby merged commit b5936ac into main May 8, 2026
15 checks passed
@yomybaby yomybaby deleted the 05-08-feat_fr-2843_make_norevision_and_private_alerts_title-only_and_use_warning_type_for_norevision branch May 8, 2026 04:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the Deployment Detail page alerts by making the “No revision deployed” and “Private deployment” notices title-only (no separate description block) and reclassifies the “No revision deployed” state as a warning. It also updates i18n resources to remove the now-unused description keys and fold their meaning into the title strings across locales.

Changes:

  • Updated DeploymentDetailPage alerts to remove description props and switch NoCurrentRevisionDeployed from info to warning.
  • Removed orphaned i18n description keys and expanded the remaining title strings to include the prior description meaning across supported locales.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
react/src/pages/DeploymentDetailPage.tsx Removes alert descriptions and changes “no revision” alert to warning to better reflect severity.
resources/i18n/en.json Removes unused description keys and enriches alert titles.
resources/i18n/de.json Removes unused description keys and enriches alert titles.
resources/i18n/el.json Removes unused description keys and enriches alert titles.
resources/i18n/es.json Removes unused description keys and enriches alert titles.
resources/i18n/fi.json Removes unused description keys and enriches alert titles.
resources/i18n/fr.json Removes unused description keys and enriches alert titles.
resources/i18n/id.json Removes unused description keys and enriches alert titles.
resources/i18n/it.json Removes unused description keys and enriches alert titles.
resources/i18n/ja.json Removes unused description keys and enriches alert titles.
resources/i18n/ko.json Removes unused description keys and enriches alert titles.
resources/i18n/mn.json Removes unused description keys and enriches alert titles.
resources/i18n/ms.json Removes unused description keys and enriches alert titles.
resources/i18n/pl.json Removes unused description keys and enriches alert titles.
resources/i18n/pt.json Removes unused description keys and enriches alert titles.
resources/i18n/pt-BR.json Removes unused description keys and enriches alert titles.
resources/i18n/ru.json Removes unused description keys and enriches alert titles.
resources/i18n/th.json Removes unused description keys and enriches alert titles.
resources/i18n/tr.json Removes unused description keys and enriches alert titles.
resources/i18n/vi.json Removes unused description keys and enriches alert titles.
resources/i18n/zh-CN.json Removes unused description keys and enriches alert titles.
resources/i18n/zh-TW.json Removes unused description keys and enriches alert titles.

Comment thread resources/i18n/zh-CN.json
Comment thread resources/i18n/zh-TW.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make deployment NoRevision and Private alerts title-only and use warning type for NoRevision

2 participants