Conversation
…warning type for NoRevision
…iched titles; warn type for NoRevision
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
This PR streamlines the Deployment Detail page alerts by making the “No revision deployed” and “Private deployment” notices title-only (no separate description block) and reclassifies the “No revision deployed” state as a warning. It also updates i18n resources to remove the now-unused description keys and fold their meaning into the title strings across locales.
Changes:
- Updated
DeploymentDetailPagealerts to removedescriptionprops and switchNoCurrentRevisionDeployedfrominfotowarning. - Removed orphaned i18n description keys and expanded the remaining title strings to include the prior description meaning across supported locales.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/pages/DeploymentDetailPage.tsx | Removes alert descriptions and changes “no revision” alert to warning to better reflect severity. |
| resources/i18n/en.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/de.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/el.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/es.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/fi.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/fr.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/id.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/it.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/ja.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/ko.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/mn.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/ms.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/pl.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/pt.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/pt-BR.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/ru.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/th.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/tr.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/vi.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/zh-CN.json | Removes unused description keys and enriches alert titles. |
| resources/i18n/zh-TW.json | Removes unused description keys and enriches alert titles. |

Resolves #7302 (FR-2843)
Summary
descriptionprop from both deployment-detail alerts (NoCurrentRevisionDeployed,PrivateDeployment) and roll the previous description content into the title text so the alerts read as a single concise line.NoCurrentRevisionDeployedfromtype="info"totype="warning"— there is no active service to serve until a revision is added, which is closer to a warning state than a neutral notice.deployment.NoCurrentRevisionDeployedDescriptionanddeployment.PrivateDeploymentAlertDescriptionacross all 22 supported languages.deployment.NoCurrentRevisionDeployedanddeployment.PrivateDeploymentAlertTitletranslations to incorporate the previous description meaning (e.g. en: 'No revision is deployed — add a revision to activate this service.').Note:
deployment.NoCurrentRevisionDeployedis also used as the<Empty>placeholder description inDeploymentConfigurationSection's "Current Revision" tab; the enriched message reads naturally there too.Test plan
NoCurrentRevisionDeployedalert renders in the warning style (yellow) instead of info (blue).PrivateDeploymentalert remains info-style.<Empty>placeholder shows the same enriched message — verify it still reads well there.