fix(FR-2849): narrow Suspense boundary in Add Revision modal for resource group change#7368
Conversation
…urce group change Wrap ResourceAllocationFormItems in its own Suspense boundary so that changing the resource group only re-suspends the resource-allocation section instead of triggering the modal-level fallback and unmounting the entire form body.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
|
There was a problem hiding this comment.
Pull request overview
Narrow the Suspense boundary behavior in the Deployment “Add Revision” modal so that changing resource-related form values only suspends (shows a loading skeleton for) the resource-allocation section, instead of triggering the modal-level fallback that unmounts the whole form body and can drop in-progress user input.
Changes:
- Wrap
ResourceAllocationFormItemsin its own<Suspense fallback={<Skeleton active />}>boundary within the form body. - Update the surrounding rationale comment to reflect the intended UX (keep the rest of the form mounted during resource-allocation re-suspends).
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Closing this PR — the underlying work will be addressed by FR-2862, which refactors the Add Revision flow (merging Deployment Content components into Modal components and adding Preset Mode). See: https://lablup.atlassian.net/browse/FR-2862 |
resolves #NNN (FR-MMM)
Checklist: (if applicable)