Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions react/src/components/DeploymentAddRevisionModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1112,13 +1112,14 @@ const DeploymentAddRevisionModalFormBody: React.FC<
`ResourceAllocationFormItems` internally uses several
`useLazyLoadQuery` calls that suspend whenever the watched
form values (resource group, image, allocation preset) change.
Those throws are caught by the modal-level Suspense fallback
above the form body — combined with the deployment query's
default `store-or-network` policy, the body remounts re-read
the cached deployment instead of re-fetching it, so the
previously observed infinite-fetch loop does not recur.
Wrap it in a dedicated Suspense boundary so that only the
resource-allocation section shows a loading skeleton on
resource-group changes — rather than the modal-level fallback
Comment thread
ironAiken2 marked this conversation as resolved.
unmounting the entire form body and losing user input.
*/}
<ResourceAllocationFormItems enableResourcePresets />
<Suspense fallback={<Skeleton active />}>
<ResourceAllocationFormItems enableResourcePresets />
</Suspense>

<Collapse
items={[
Expand Down
Loading