feat(FR-2905): deployment list polish — projectV2 display, revision drawer link, drop createdUserId, strictSelection on enum filters#7439
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
90c3cf4 to
0e432f5
Compare
0e432f5 to
621cea0
Compare
There was a problem hiding this comment.
Pull request overview
This PR polishes the model deployment list and replicas tab UX by improving Project display in the admin list, adding a revision-detail drawer entrypoint from the deployment list, tightening enum filter input behavior, and removing redundant “Creator ID” UI/filter surface (including its i18n keys).
Changes:
- Admin deployment list: render Project as
project name (ID)usingmetadata.projectV2.basicInfo.name @since(version: "26.4.3")while keeping the ID copyable viaBAIId. - Deployment list: make the Applied Revision Number column open
DeploymentRevisionDetailDrawerand spread...DeploymentRevisionDetail_revisionintocurrentRevision. - Cleanup: remove
createdUserIdcolumn/filter and delete the orphandeployment.filter.CreatedUserIdtranslation key from all locales; enforcestrictSelection: truefor the replicas tabtrafficStatusenum filter.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| react/src/components/DeploymentList.tsx | Adds projectV2 name display for admin Project column, removes createdUserId surfaces, and opens revision detail drawer from revision number link. |
| react/src/components/DeploymentReplicasTab.tsx | Forces strict selection for trafficStatus enum filter and adjusts secondary styling around IDs in the session/revision columns. |
| resources/i18n/en.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/de.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/el.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/es.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/fi.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/fr.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/id.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/it.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/ja.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/ko.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/mn.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/ms.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/pl.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/pt-BR.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/pt.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/ru.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/th.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/tr.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/vi.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/zh-CN.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
| resources/i18n/zh-TW.json | Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column. |
4e93178 to
274dd2a
Compare
Merge activity
|
bb91225 to
b82b552
Compare
…rawer link, drop createdUserId, strictSelection on enum filters (#7439) Resolves #7438([FR-2905](https://lablup.atlassian.net/browse/FR-2905)) Stacked on top of #7437. ## Summary Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention. - **Admin deployment list — Project column.** Replaced the raw project-ID cell with a `project name (BAIId)` cell. Name comes from `metadata.projectV2.basicInfo.name @SInCE(version: "26.4.3")` (DataLoader-resolved). ID stays copyable + ellipsis via `BAIId`. - **Deployment list — Revision number drawer link.** The Applied-Revision column now opens `DeploymentRevisionDetailDrawer` on click, matching the pattern used in `DeploymentReplicasTab`. The `currentRevision` fragment ref is spread into `...DeploymentRevisionDetail_revision` for the drawer. - **Drop `createdUserId` from the deployment list.** Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via `DeploymentOwnerInfo`. Orphan i18n key `deployment.filter.CreatedUserId` was removed from all 21 locale files. - **Property filter — `strictSelection: true` on enum types.** Applied to the `trafficStatus` enum filter in `DeploymentReplicasTab` so the value must come from the provided options. ## Test plan - [ ] Admin deployment list: open column settings, toggle the `Project` column on → confirm `project name (ID)` renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager). - [ ] Deployment list: enable the Revision Number column → click the link → confirm `DeploymentRevisionDetailDrawer` opens with the right revision. - [ ] Admin deployment list: confirm the `Creator ID` column and the `Creator ID` admin filter are no longer present. - [ ] Replicas tab: open the property filter, choose `TrafficStatus` → confirm input requires selection from `Active` / `Inactive` (typing arbitrary text is rejected). - [ ] `bash scripts/verify.sh` — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages. [FR-2905]: https://lablup.atlassian.net/browse/FR-2905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
274dd2a to
33d5807
Compare
33d5807 to
910efff
Compare
…rawer link, drop createdUserId, strictSelection on enum filters (#7439) Resolves #7438([FR-2905](https://lablup.atlassian.net/browse/FR-2905)) Stacked on top of #7437. ## Summary Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention. - **Admin deployment list — Project column.** Replaced the raw project-ID cell with a `project name (BAIId)` cell. Name comes from `metadata.projectV2.basicInfo.name @SInCE(version: "26.4.3")` (DataLoader-resolved). ID stays copyable + ellipsis via `BAIId`. - **Deployment list — Revision number drawer link.** The Applied-Revision column now opens `DeploymentRevisionDetailDrawer` on click, matching the pattern used in `DeploymentReplicasTab`. The `currentRevision` fragment ref is spread into `...DeploymentRevisionDetail_revision` for the drawer. - **Drop `createdUserId` from the deployment list.** Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via `DeploymentOwnerInfo`. Orphan i18n key `deployment.filter.CreatedUserId` was removed from all 21 locale files. - **Property filter — `strictSelection: true` on enum types.** Applied to the `trafficStatus` enum filter in `DeploymentReplicasTab` so the value must come from the provided options. ## Test plan - [ ] Admin deployment list: open column settings, toggle the `Project` column on → confirm `project name (ID)` renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager). - [ ] Deployment list: enable the Revision Number column → click the link → confirm `DeploymentRevisionDetailDrawer` opens with the right revision. - [ ] Admin deployment list: confirm the `Creator ID` column and the `Creator ID` admin filter are no longer present. - [ ] Replicas tab: open the property filter, choose `TrafficStatus` → confirm input requires selection from `Active` / `Inactive` (typing arbitrary text is rejected). - [ ] `bash scripts/verify.sh` — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages. [FR-2905]: https://lablup.atlassian.net/browse/FR-2905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
910efff to
674da9d
Compare

Resolves #7438(FR-2905)
Stacked on top of #7437.
Summary
Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention.
project name (BAIId)cell. Name comes frommetadata.projectV2.basicInfo.name @since(version: "26.4.3")(DataLoader-resolved). ID stays copyable + ellipsis viaBAIId.DeploymentRevisionDetailDraweron click, matching the pattern used inDeploymentReplicasTab. ThecurrentRevisionfragment ref is spread into...DeploymentRevisionDetail_revisionfor the drawer.createdUserIdfrom the deployment list. Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information viaDeploymentOwnerInfo. Orphan i18n keydeployment.filter.CreatedUserIdwas removed from all 21 locale files.strictSelection: trueon enum types. Applied to thetrafficStatusenum filter inDeploymentReplicasTabso the value must come from the provided options.Test plan
Projectcolumn on → confirmproject name (ID)renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager).DeploymentRevisionDetailDraweropens with the right revision.Creator IDcolumn and theCreator IDadmin filter are no longer present.TrafficStatus→ confirm input requires selection fromActive/Inactive(typing arbitrary text is rejected).bash scripts/verify.sh— Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages.