Skip to content

feat(FR-2905): deployment list polish — projectV2 display, revision drawer link, drop createdUserId, strictSelection on enum filters#7439

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat/FR-2905-deployment-list-polish
May 15, 2026
Merged

feat(FR-2905): deployment list polish — projectV2 display, revision drawer link, drop createdUserId, strictSelection on enum filters#7439
graphite-app[bot] merged 1 commit into
mainfrom
feat/FR-2905-deployment-list-polish

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 15, 2026

Resolves #7438(FR-2905)

Stacked on top of #7437.

Summary

Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention.

  • Admin deployment list — Project column. Replaced the raw project-ID cell with a project name (BAIId) cell. Name comes from metadata.projectV2.basicInfo.name @since(version: "26.4.3") (DataLoader-resolved). ID stays copyable + ellipsis via BAIId.
  • Deployment list — Revision number drawer link. The Applied-Revision column now opens DeploymentRevisionDetailDrawer on click, matching the pattern used in DeploymentReplicasTab. The currentRevision fragment ref is spread into ...DeploymentRevisionDetail_revision for the drawer.
  • Drop createdUserId from the deployment list. Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via DeploymentOwnerInfo. Orphan i18n key deployment.filter.CreatedUserId was removed from all 21 locale files.
  • Property filter — strictSelection: true on enum types. Applied to the trafficStatus enum filter in DeploymentReplicasTab so the value must come from the provided options.

Test plan

  • Admin deployment list: open column settings, toggle the Project column on → confirm project name (ID) renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager).
  • Deployment list: enable the Revision Number column → click the link → confirm DeploymentRevisionDetailDrawer opens with the right revision.
  • Admin deployment list: confirm the Creator ID column and the Creator ID admin filter are no longer present.
  • Replicas tab: open the property filter, choose TrafficStatus → confirm input requires selection from Active / Inactive (typing arbitrary text is rejected).
  • bash scripts/verify.sh — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:M 30~100 LoC labels May 15, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented May 15, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.51% 1785 / 27403
🔵 Statements 5.35% 1980 / 36960
🔵 Functions 5.25% 296 / 5638
🔵 Branches 3.74% 1293 / 34541
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/components/DeploymentConfigurationSection.tsx 0% 0% 0% 0% 72-315
react/src/components/DeploymentList.tsx 0% 0% 0% 0% 56-547
react/src/components/DeploymentReplicasTab.tsx 0% 0% 0% 0% 46-491
react/src/components/DeploymentSettingModal.tsx 0% 0% 0% 0% 48-232
Generated in workflow #806 for commit 674da9d by the Vitest Coverage Report Action

@yomybaby yomybaby force-pushed the feat/FR-2905-deployment-list-polish branch 2 times, most recently from 90c3cf4 to 0e432f5 Compare May 15, 2026 11:46
@github-actions github-actions Bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels May 15, 2026
@yomybaby yomybaby marked this pull request as ready for review May 15, 2026 11:47
Copilot AI review requested due to automatic review settings May 15, 2026 11:48
@yomybaby yomybaby force-pushed the feat/FR-2905-deployment-list-polish branch from 0e432f5 to 621cea0 Compare May 15, 2026 11:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the model deployment list and replicas tab UX by improving Project display in the admin list, adding a revision-detail drawer entrypoint from the deployment list, tightening enum filter input behavior, and removing redundant “Creator ID” UI/filter surface (including its i18n keys).

Changes:

  • Admin deployment list: render Project as project name (ID) using metadata.projectV2.basicInfo.name @since(version: "26.4.3") while keeping the ID copyable via BAIId.
  • Deployment list: make the Applied Revision Number column open DeploymentRevisionDetailDrawer and spread ...DeploymentRevisionDetail_revision into currentRevision.
  • Cleanup: remove createdUserId column/filter and delete the orphan deployment.filter.CreatedUserId translation key from all locales; enforce strictSelection: true for the replicas tab trafficStatus enum filter.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
react/src/components/DeploymentList.tsx Adds projectV2 name display for admin Project column, removes createdUserId surfaces, and opens revision detail drawer from revision number link.
react/src/components/DeploymentReplicasTab.tsx Forces strict selection for trafficStatus enum filter and adjusts secondary styling around IDs in the session/revision columns.
resources/i18n/en.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/de.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/el.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/es.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/fi.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/fr.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/id.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/it.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/ja.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/ko.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/mn.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/ms.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/pl.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/pt-BR.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/pt.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/ru.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/th.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/tr.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/vi.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/zh-CN.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.
resources/i18n/zh-TW.json Removes orphan deployment.filter.CreatedUserId key after dropping the corresponding filter/column.

Comment thread react/src/components/DeploymentList.tsx
@yomybaby yomybaby force-pushed the feat/FR-2905-deployment-list-polish branch 3 times, most recently from 4e93178 to 274dd2a Compare May 15, 2026 12:11
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 15, 2026

Merge activity

@graphite-app graphite-app Bot force-pushed the feat/FR-2904-replica-status-radio-group branch from bb91225 to b82b552 Compare May 15, 2026 12:14
graphite-app Bot pushed a commit that referenced this pull request May 15, 2026
…rawer link, drop createdUserId, strictSelection on enum filters (#7439)

Resolves #7438([FR-2905](https://lablup.atlassian.net/browse/FR-2905))

Stacked on top of #7437.

## Summary

Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention.

- **Admin deployment list — Project column.** Replaced the raw project-ID cell with a `project name (BAIId)` cell. Name comes from `metadata.projectV2.basicInfo.name @SInCE(version: "26.4.3")` (DataLoader-resolved). ID stays copyable + ellipsis via `BAIId`.
- **Deployment list — Revision number drawer link.** The Applied-Revision column now opens `DeploymentRevisionDetailDrawer` on click, matching the pattern used in `DeploymentReplicasTab`. The `currentRevision` fragment ref is spread into `...DeploymentRevisionDetail_revision` for the drawer.
- **Drop `createdUserId` from the deployment list.** Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via `DeploymentOwnerInfo`. Orphan i18n key `deployment.filter.CreatedUserId` was removed from all 21 locale files.
- **Property filter — `strictSelection: true` on enum types.** Applied to the `trafficStatus` enum filter in `DeploymentReplicasTab` so the value must come from the provided options.

## Test plan

- [ ] Admin deployment list: open column settings, toggle the `Project` column on → confirm `project name (ID)` renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager).
- [ ] Deployment list: enable the Revision Number column → click the link → confirm `DeploymentRevisionDetailDrawer` opens with the right revision.
- [ ] Admin deployment list: confirm the `Creator ID` column and the `Creator ID` admin filter are no longer present.
- [ ] Replicas tab: open the property filter, choose `TrafficStatus` → confirm input requires selection from `Active` / `Inactive` (typing arbitrary text is rejected).
- [ ] `bash scripts/verify.sh` — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages.

[FR-2905]: https://lablup.atlassian.net/browse/FR-2905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the feat/FR-2905-deployment-list-polish branch from 274dd2a to 33d5807 Compare May 15, 2026 12:14
Base automatically changed from feat/FR-2904-replica-status-radio-group to main May 15, 2026 12:17
@yomybaby yomybaby force-pushed the feat/FR-2905-deployment-list-polish branch from 33d5807 to 910efff Compare May 15, 2026 12:19
…rawer link, drop createdUserId, strictSelection on enum filters (#7439)

Resolves #7438([FR-2905](https://lablup.atlassian.net/browse/FR-2905))

Stacked on top of #7437.

## Summary

Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention.

- **Admin deployment list — Project column.** Replaced the raw project-ID cell with a `project name (BAIId)` cell. Name comes from `metadata.projectV2.basicInfo.name @SInCE(version: "26.4.3")` (DataLoader-resolved). ID stays copyable + ellipsis via `BAIId`.
- **Deployment list — Revision number drawer link.** The Applied-Revision column now opens `DeploymentRevisionDetailDrawer` on click, matching the pattern used in `DeploymentReplicasTab`. The `currentRevision` fragment ref is spread into `...DeploymentRevisionDetail_revision` for the drawer.
- **Drop `createdUserId` from the deployment list.** Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via `DeploymentOwnerInfo`. Orphan i18n key `deployment.filter.CreatedUserId` was removed from all 21 locale files.
- **Property filter — `strictSelection: true` on enum types.** Applied to the `trafficStatus` enum filter in `DeploymentReplicasTab` so the value must come from the provided options.

## Test plan

- [ ] Admin deployment list: open column settings, toggle the `Project` column on → confirm `project name (ID)` renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager).
- [ ] Deployment list: enable the Revision Number column → click the link → confirm `DeploymentRevisionDetailDrawer` opens with the right revision.
- [ ] Admin deployment list: confirm the `Creator ID` column and the `Creator ID` admin filter are no longer present.
- [ ] Replicas tab: open the property filter, choose `TrafficStatus` → confirm input requires selection from `Active` / `Inactive` (typing arbitrary text is rejected).
- [ ] `bash scripts/verify.sh` — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages.

[FR-2905]: https://lablup.atlassian.net/browse/FR-2905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the feat/FR-2905-deployment-list-polish branch from 910efff to 674da9d Compare May 15, 2026 12:21
@graphite-app graphite-app Bot merged commit 674da9d into main May 15, 2026
12 checks passed
@graphite-app graphite-app Bot deleted the feat/FR-2905-deployment-list-polish branch May 15, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. frontend size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment list polish — projectV2 display, revision drawer link, drop createdUserId, strictSelection on enum filters

2 participants