feat(FR-2904): replace replica status enum filter with running/terminated radio group by agatha197 · Pull Request #7437 · lablup/backend.ai-webui

agatha197 · 2026-05-15T09:32:26Z

Resolves #7434 (FR-2904)

Stacked on top of #7435.

Summary

Removed the status enum option from BAIGraphQLPropertyFilter in DeploymentReplicasTab and replaced it with a BAIRadioGroup (Running / Terminated), mirroring the deployment list pattern.
Running selects every status except TERMINATED (status.notIn: ['TERMINATED']); Terminated selects only TERMINATED.
The category persists in the URL via a new rStatusCategory query param and merges with the user-defined filter at query time, so toggling the category does not clobber other filters.
Removed the now-unused replicaStatusOptions and the WARMING_UP TODO comment block.

Test plan

Open a deployment's Replicas tab — verify the Running / Terminated radio appears next to the property filter.
Toggle to Terminated — verify only TERMINATED replicas show; toggle back to Running — verify all other statuses show.
Apply a trafficStatus filter, then toggle the radio — verify both filters apply (not overwritten).
Refresh the page with a non-default rStatusCategory in the URL — verify the radio reflects the URL state.
bash scripts/verify.sh passes.

agatha197 · 2026-05-15T09:32:42Z

feat(FR-2905): deployment list polish — projectV2 display, revision drawer link, drop createdUserId, strictSelection on enum filters #7439
feat(FR-2904): replace replica status enum filter with running/terminated radio group #7437 👈 (View in Graphite)
feat(FR-2904): expose all DeploymentFilter fields, ordering, and table columns in deployment list #7435 : 1 other dependent PR (#7436 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-05-15T09:34:52Z

Coverage Report for react-coverage (./react)

Status	Category	Percentage	Covered / Total
🔵	Lines	6.51%	1785 / 27388
🔵	Statements	5.36%	1980 / 36936
🔵	Functions	5.25%	296 / 5634
🔵	Branches	3.74%	1293 / 34533

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
react/src/components/DeploymentReplicasTab.tsx	0%	0%	0%	0%	46-491

Generated in workflow #803 for commit b82b552 by the Vitest Coverage Report Action

Copilot

Pull request overview

Updates the Deployment Replicas tab filtering UX to match the deployment list pattern by replacing the replica status enum property filter with a persisted Running/Terminated radio category that composes with the existing GraphQL property filter.

Changes:

Replaced the replica status enum filter option with a BAIRadioGroup toggle (Running vs Terminated).
Added rStatusCategory as a URL query param and merged it into the GraphQL ReplicaFilter at query/refetch time.
Removed the now-unused replicaStatusOptions and the stale WARMING_UP TODO block.

yomybaby

LGTM

graphite-app · 2026-05-15T12:12:53Z

Merge activity

May 15, 12:12 PM UTC: yomybaby added this pull request to the Graphite merge queue.
May 15, 12:17 PM UTC: Merged by the Graphite merge queue.

…ated radio group (#7437) Resolves #7434 ([FR-2904](https://lablup.atlassian.net/browse/FR-2904)) Stacked on top of #7435. ## Summary - Removed the `status` enum option from `BAIGraphQLPropertyFilter` in `DeploymentReplicasTab` and replaced it with a `BAIRadioGroup` (`Running` / `Terminated`), mirroring the deployment list pattern. - `Running` selects every status except `TERMINATED` (`status.notIn: ['TERMINATED']`); `Terminated` selects only `TERMINATED`. - The category persists in the URL via a new `rStatusCategory` query param and merges with the user-defined filter at query time, so toggling the category does not clobber other filters. - Removed the now-unused `replicaStatusOptions` and the `WARMING_UP` TODO comment block. ## Test plan - [ ] Open a deployment's Replicas tab — verify the `Running` / `Terminated` radio appears next to the property filter. - [ ] Toggle to `Terminated` — verify only `TERMINATED` replicas show; toggle back to `Running` — verify all other statuses show. - [ ] Apply a `trafficStatus` filter, then toggle the radio — verify both filters apply (not overwritten). - [ ] Refresh the page with a non-default `rStatusCategory` in the URL — verify the radio reflects the URL state. - [ ] `bash scripts/verify.sh` passes. [FR-2904]: https://lablup.atlassian.net/browse/FR-2904?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

@SInCE

…rawer link, drop createdUserId, strictSelection on enum filters (#7439) Resolves #7438([FR-2905](https://lablup.atlassian.net/browse/FR-2905)) Stacked on top of #7437. ## Summary Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention. - **Admin deployment list — Project column.** Replaced the raw project-ID cell with a `project name (BAIId)` cell. Name comes from `metadata.projectV2.basicInfo.name @SInCE(version: "26.4.3")` (DataLoader-resolved). ID stays copyable + ellipsis via `BAIId`. - **Deployment list — Revision number drawer link.** The Applied-Revision column now opens `DeploymentRevisionDetailDrawer` on click, matching the pattern used in `DeploymentReplicasTab`. The `currentRevision` fragment ref is spread into `...DeploymentRevisionDetail_revision` for the drawer. - **Drop `createdUserId` from the deployment list.** Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via `DeploymentOwnerInfo`. Orphan i18n key `deployment.filter.CreatedUserId` was removed from all 21 locale files. - **Property filter — `strictSelection: true` on enum types.** Applied to the `trafficStatus` enum filter in `DeploymentReplicasTab` so the value must come from the provided options. ## Test plan - [ ] Admin deployment list: open column settings, toggle the `Project` column on → confirm `project name (ID)` renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager). - [ ] Deployment list: enable the Revision Number column → click the link → confirm `DeploymentRevisionDetailDrawer` opens with the right revision. - [ ] Admin deployment list: confirm the `Creator ID` column and the `Creator ID` admin filter are no longer present. - [ ] Replicas tab: open the property filter, choose `TrafficStatus` → confirm input requires selection from `Active` / `Inactive` (typing arbitrary text is rejected). - [ ] `bash scripts/verify.sh` — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages. [FR-2905]: https://lablup.atlassian.net/browse/FR-2905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

@SInCE

…rawer link, drop createdUserId, strictSelection on enum filters (#7439) Resolves #7438([FR-2905](https://lablup.atlassian.net/browse/FR-2905)) Stacked on top of #7437. ## Summary Follow-up polish on the deployment list & replicas tab (FR-2904 series). Bundled as one PR per the project's "avoid excessive PR splitting" convention. - **Admin deployment list — Project column.** Replaced the raw project-ID cell with a `project name (BAIId)` cell. Name comes from `metadata.projectV2.basicInfo.name @SInCE(version: "26.4.3")` (DataLoader-resolved). ID stays copyable + ellipsis via `BAIId`. - **Deployment list — Revision number drawer link.** The Applied-Revision column now opens `DeploymentRevisionDetailDrawer` on click, matching the pattern used in `DeploymentReplicasTab`. The `currentRevision` fragment ref is spread into `...DeploymentRevisionDetail_revision` for the drawer. - **Drop `createdUserId` from the deployment list.** Both the admin column and the matching filter property were removed — the existing Owner / Creator column already surfaces the same information via `DeploymentOwnerInfo`. Orphan i18n key `deployment.filter.CreatedUserId` was removed from all 21 locale files. - **Property filter — `strictSelection: true` on enum types.** Applied to the `trafficStatus` enum filter in `DeploymentReplicasTab` so the value must come from the provided options. ## Test plan - [ ] Admin deployment list: open column settings, toggle the `Project` column on → confirm `project name (ID)` renders for deployments that have a project, and only the ID shows when name is unavailable (≤ 26.4.2 manager). - [ ] Deployment list: enable the Revision Number column → click the link → confirm `DeploymentRevisionDetailDrawer` opens with the right revision. - [ ] Admin deployment list: confirm the `Creator ID` column and the `Creator ID` admin filter are no longer present. - [ ] Replicas tab: open the property filter, choose `TrafficStatus` → confirm input requires selection from `Active` / `Inactive` (typing arbitrary text is rejected). - [ ] `bash scripts/verify.sh` — Relay / Lint / Format pass; TypeScript only reports pre-existing errors in unrelated pages. [FR-2905]: https://lablup.atlassian.net/browse/FR-2905?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions Bot added the size:M 30~100 LoC label May 15, 2026

github-actions Bot assigned agatha197 May 15, 2026

agatha197 mentioned this pull request May 15, 2026

feat(FR-2904): expose all DeploymentFilter fields, ordering, and table columns in deployment list #7435

Merged

5 tasks

agatha197 mentioned this pull request May 15, 2026

feat(FR-2904): replace replica status enum filter with running/terminated radio group #7436

Closed

5 tasks

agatha197 marked this pull request as ready for review May 15, 2026 09:33

Copilot AI review requested due to automatic review settings May 15, 2026 09:33

Copilot started reviewing on behalf of agatha197 May 15, 2026 09:34 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread react/src/components/DeploymentReplicasTab.tsx

agatha197 force-pushed the feat/FR-2904-extend-deployment-list-filters-columns branch from f355bff to 5fd7e9b Compare May 15, 2026 09:37

agatha197 force-pushed the feat/FR-2904-replica-status-radio-group branch from 97f2c97 to bb91225 Compare May 15, 2026 09:37

agatha197 requested review from nowgnuesLee and yomybaby May 15, 2026 09:41

yomybaby mentioned this pull request May 15, 2026

feat(FR-2905): deployment list polish — projectV2 display, revision drawer link, drop createdUserId, strictSelection on enum filters #7439

Merged

5 tasks

yomybaby approved these changes May 15, 2026

View reviewed changes

graphite-app Bot force-pushed the feat/FR-2904-extend-deployment-list-filters-columns branch from 5fd7e9b to ac8cb71 Compare May 15, 2026 12:13

graphite-app Bot force-pushed the feat/FR-2904-replica-status-radio-group branch from bb91225 to b82b552 Compare May 15, 2026 12:14

Base automatically changed from feat/FR-2904-extend-deployment-list-filters-columns to main May 15, 2026 12:16

graphite-app Bot merged commit b82b552 into main May 15, 2026
8 checks passed

graphite-app Bot deleted the feat/FR-2904-replica-status-radio-group branch May 15, 2026 12:17

github-pages Bot temporarily deployed to github-pages May 15, 2026 12:17 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2904): replace replica status enum filter with running/terminated radio group#7437

feat(FR-2904): replace replica status enum filter with running/terminated radio group#7437
graphite-app[bot] merged 1 commit into
mainfrom
feat/FR-2904-replica-status-radio-group

agatha197 commented May 15, 2026 •

edited by atlassian Bot

Loading

Uh oh!

agatha197 commented May 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

yomybaby left a comment

Uh oh!

graphite-app Bot commented May 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

agatha197 commented May 15, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

agatha197 commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for react-coverage (./react)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agatha197 commented May 15, 2026 •

edited by atlassian Bot

Loading

agatha197 commented May 15, 2026 •

edited

Loading

github-actions Bot commented May 15, 2026 •

edited

Loading

graphite-app Bot commented May 15, 2026 •

edited

Loading