Conversation
cod43156
commented
Oct 1, 2024
| Q | A |
|---|---|
| Documentation | yes/no |
| Bugfix | yes/no |
| BC Break | yes/no |
| New Feature | yes/no |
| RFC | yes/no |
| QA | yes/no |
651a732 to
30b6baa
Compare
|
Hi @gsteel, the build is failing as the containers are not starting up correctly. Could you advise if there are any known build issues with this repository? |
|
Here’s a polite and professional comment you can add to request an update: Hello @gsteel, Just following up on the earlier comment regarding the build issues with this repository. Could you kindly confirm if there's anything pending from my side to assist in resolving this? Please let me know if I can help in any way. Thank you for your time and support! |
|
When 8.3 was new it had the same problem #293 Looks like mssql hasn't updated for 8.4 yet https://github.com/Microsoft/msphpsql/releases |
404241e to
6f0b590
Compare
|
@froschdesign @gsteel Would you be able to provide some guidance on how you'd like me to proceed with this? I'm happy to help in any way I can. |
|
@cod43156 Thanks for the offer of help. I don't use or know laminas-db very well so please stop pinging me. Hopefully someone else on the @laminas/technical-steering-committee will be able to offer you some guidance. |
|
@cod43156 please rebase and let see if the CI is now working |
6f0b590 to
d2e79d6
Compare
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
a52a730 to
e810672
Compare
|
I've rebased the branch, but unfortunately, two builds are still failing due to the unavailability of the php8.4-sqlsrv extension. |
|
fyi: "...don't have an exact timeline for the next PHP driver release, but it's likely at least a couple quarters out." |
|
If Microsoft adds support for the PHP 8.4 driver, can we expect that laminas/db will also gain 8.4 support? |
|
@YuraKril |
|
Hello, Any plan to release a version without SQL Server support? |
No, because that means a BC break and since this component only receives security updates, this will not happen. |
|
Things are finally moving forward: microsoft/msphpsql#1539 (comment) |
|
8.4 and 8.5 mssql out microsoft/msphpsql#1523 (comment) |
|
@cod43156 could you rebase latest 2.21.x branch to restart build? Thank you. |
|
I am looking forward to the new release. |
|
Pretty much the only package left in our stack that doesn't support PHP 8.4+. |
|
@cod43156 can you help with our overall pain? :) thanks! |
|
Let's close-reopen PR to see if the build now green |
|
php 8.4 lowest dependency seems need phpunit upgrade https://github.com/laminas/laminas-db/actions/runs/23253801926/job/67602949552?pr=312#step:4:532 |
|
Thanks for your help @samsonasik |
|
In order to keep the tests functionality and code coverage and run on PHP 8.4 the minimum PHPUnit version is 11. @cod43156 and @samsonasik in this PR cod43156#3 PHPUnit is updated to 11.5. The minimum supported version of laminas-db is changed to >= 8.2. PHPUnit 11 does not run on PHP 8.1. PHPUnit 10 runs but does not support method coverage. |
|
I guess no need to bump php requirement, unless we are going to support php 8.5, which probably not going to be supported (at least on this PR purpose). Run |
|
If we support PHP 8.1 then we need PHPUnit that installs and runs on PHP 8.1. PHPUnit 10 should be fine. To support method-level coverage attributes, PHPUnit 11.1 or higher is required. Since PHPUnit 11.1 mandates PHP 8.2+, this change effectively raises the minimum PHP requirement for the project. |
|
PHP 8.1 is EOL, and should be dropped regardless |
|
No, php 8.4 latest is working ok, that means bump phpunit 9 (should be If we are going to remove php 8.1 support, that need separate PR, then allow php 8.5 as well there, which not the purpose of this PR. |
It works. Thank you @samsonasik. The PR is here: cod43156#4 |
|
@slaff could you send PR to this repo? Thank you. |