Skip to content

PHP8.4 Support Added#312

Merged
samsonasik merged 4 commits intolaminas:2.21.xfrom
cod43156:php8.4_support
Mar 20, 2026
Merged

PHP8.4 Support Added#312
samsonasik merged 4 commits intolaminas:2.21.xfrom
cod43156:php8.4_support

Conversation

@cod43156
Copy link
Contributor

@cod43156 cod43156 commented Oct 1, 2024

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

@cod43156 cod43156 force-pushed the php8.4_support branch 2 times, most recently from 651a732 to 30b6baa Compare October 14, 2024 09:54
@cod43156
Copy link
Contributor Author

Hi @gsteel, the build is failing as the containers are not starting up correctly. Could you advise if there are any known build issues with this repository?

@cod43156
Copy link
Contributor Author

Here’s a polite and professional comment you can add to request an update:


Hello @gsteel, Just following up on the earlier comment regarding the build issues with this repository. Could you kindly confirm if there's anything pending from my side to assist in resolving this? Please let me know if I can help in any way.

Thank you for your time and support!

@happydude
Copy link

When 8.3 was new it had the same problem #293

Looks like mssql hasn't updated for 8.4 yet https://github.com/Microsoft/msphpsql/releases

@cod43156 cod43156 force-pushed the php8.4_support branch 2 times, most recently from 404241e to 6f0b590 Compare January 3, 2025 16:18
@cod43156
Copy link
Contributor Author

@froschdesign @gsteel Would you be able to provide some guidance on how you'd like me to proceed with this? I'm happy to help in any way I can.

@gsteel
Copy link
Member

gsteel commented Jan 27, 2025

@cod43156 Thanks for the offer of help.

I don't use or know laminas-db very well so please stop pinging me.

Hopefully someone else on the @laminas/technical-steering-committee will be able to offer you some guidance.

@froschdesign
Copy link
Member

@cod43156
Please check #317.

@samsonasik
Copy link
Member

@cod43156 please rebase and let see if the CI is now working

Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan <cod43156@adobe.com>
@cod43156
Copy link
Contributor Author

cod43156 commented Feb 5, 2025

I've rebased the branch, but unfortunately, two builds are still failing due to the unavailability of the php8.4-sqlsrv extension.

@gsteel
Copy link
Member

gsteel commented Feb 5, 2025

No release yet:

@happydude
Copy link

fyi:

"...don't have an exact timeline for the next PHP driver release, but it's likely at least a couple quarters out."

microsoft/msphpsql#1526 (comment)

@YuraKril
Copy link

YuraKril commented Jun 3, 2025

If Microsoft adds support for the PHP 8.4 driver, can we expect that laminas/db will also gain 8.4 support?

@froschdesign
Copy link
Member

@YuraKril
Correct.

@blat
Copy link

blat commented Jul 1, 2025

Hello,

Any plan to release a version without SQL Server support?
I'm stuck with PHP 8.3 due to Microsoft even if I don't use SQL Server...

@froschdesign
Copy link
Member

@blat

Any plan to release a version without SQL Server support?

No, because that means a BC break and since this component only receives security updates, this will not happen.
Please contact Microsoft because other users and dependent libraries are still waiting for an update: microsoft/msphpsql#1523

@froschdesign
Copy link
Member

Things are finally moving forward: microsoft/msphpsql#1539 (comment)

@happydude
Copy link

8.4 and 8.5 mssql out microsoft/msphpsql#1523 (comment)

@samsonasik
Copy link
Member

@cod43156 could you rebase latest 2.21.x branch to restart build? Thank you.

@mano87
Copy link

mano87 commented Mar 4, 2026

I am looking forward to the new release.

@willy-opale
Copy link

Pretty much the only package left in our stack that doesn't support PHP 8.4+.

@lon9man
Copy link

lon9man commented Mar 18, 2026

@cod43156 can you help with our overall pain? :)

thanks!

@samsonasik samsonasik closed this Mar 18, 2026
@samsonasik samsonasik reopened this Mar 18, 2026
@samsonasik
Copy link
Member

Let's close-reopen PR to see if the build now green

@samsonasik
Copy link
Member

php 8.4 lowest dependency seems need phpunit upgrade https://github.com/laminas/laminas-db/actions/runs/23253801926/job/67602949552?pr=312#step:4:532

@willy-opale
Copy link

Thanks for your help @samsonasik

@slaff
Copy link

slaff commented Mar 20, 2026

In order to keep the tests functionality and code coverage and run on PHP 8.4 the minimum PHPUnit version is 11.

@cod43156 and @samsonasik in this PR cod43156#3 PHPUnit is updated to 11.5.

The minimum supported version of laminas-db is changed to >= 8.2. PHPUnit 11 does not run on PHP 8.1. PHPUnit 10 runs but does not support method coverage.

@samsonasik
Copy link
Member

I guess no need to bump php requirement, unless we are going to support php 8.5, which probably not going to be supported (at least on this PR purpose).

Run composer bump should bump to latest phpunit support php 8.1

@slaff
Copy link

slaff commented Mar 20, 2026

If we support PHP 8.1 then we need PHPUnit that installs and runs on PHP 8.1. PHPUnit 10 should be fine.

To support method-level coverage attributes, PHPUnit 11.1 or higher is required. Since PHPUnit 11.1 mandates PHP 8.2+, this change effectively raises the minimum PHP requirement for the project.

@Ocramius
Copy link
Member

PHP 8.1 is EOL, and should be dropped regardless

@samsonasik
Copy link
Member

No, php 8.4 latest is working ok, that means bump phpunit 9 (should be ^9.6.34) to latest is fine. This PR should not bump php to 8.2, only allow php 8.4

If we are going to remove php 8.1 support, that need separate PR, then allow php 8.5 as well there, which not the purpose of this PR.

@slaff
Copy link

slaff commented Mar 20, 2026

No, php 8.4 latest is working ok, that means bump phpunit 9 (should be ^9.6.34) to latest is fine.

It works. Thank you @samsonasik. The PR is here: cod43156#4

@samsonasik
Copy link
Member

@slaff could you send PR to this repo? Thank you.

@samsonasik samsonasik merged commit e810672 into laminas:2.21.x Mar 20, 2026
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.