Skip to content

Conversation

lucasmerlin
Copy link
Contributor

@lucasmerlin lucasmerlin commented Apr 24, 2025

I wanted to patch rerun to the latest egui master, egui_commonmark failed to compile, so here is the fix! I'll convert this to the actual egui update once egui 0.32 is out.

@xangelix
Copy link

xangelix commented Apr 27, 2025

@lucasmerlin just a small heads up in case not aware, links are broken after emilk/egui@557bd56

The text turns blue but isn't actually interact-able. Lmk if you are unable to reproduce.

(#77)

@lucasmerlin
Copy link
Contributor Author

lucasmerlin commented Apr 30, 2025

Ah you're right, it's also broken for us: rerun-io/rerun#9103 (comment)

Edit:
Made an issue and a reproduction: emilk/egui#6904

Edit2:

Fix is here: emilk/egui#6905

# Conflicts:
#	egui_commonmark_backend/src/elements.rs
#	egui_commonmark_backend/src/misc.rs
@lucasmerlin
Copy link
Contributor Author

lucasmerlin commented Jul 9, 2025

Needs one more cargo update once emilk/egui#7320 is merged Done!

@lucasmerlin lucasmerlin marked this pull request as ready for review July 9, 2025 16:20
@lucasmerlin lucasmerlin changed the title Update egui to latest master Update egui to 0.32 Jul 10, 2025
@lucasmerlin
Copy link
Contributor Author

@lampsitter egui 0.32 is out 🎉 So this can now be merged

@lampsitter lampsitter merged commit 05b9715 into lampsitter:master Jul 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants