Skip to content

Comments

fix: evaluate clusterEnabled flag for clickhouse env#255

Merged
Steffen911 merged 2 commits intomainfrom
steffen/patch-cluster-mode-external-ch
Oct 14, 2025
Merged

fix: evaluate clusterEnabled flag for clickhouse env#255
Steffen911 merged 2 commits intomainfrom
steffen/patch-cluster-mode-external-ch

Conversation

@Steffen911
Copy link
Member

@Steffen911 Steffen911 commented Oct 14, 2025

Important

Evaluates clickhouse.clusterEnabled to correctly set CLICKHOUSE_CLUSTER_ENABLED in ClickHouse environments, with tests added for verification.

  • Behavior:
    • Evaluates clickhouse.clusterEnabled to set CLICKHOUSE_CLUSTER_ENABLED in _helpers.tpl.
    • Sets CLICKHOUSE_CLUSTER_ENABLED to false if clusterEnabled is false or if deploying a single-replica ClickHouse.
    • Does not set CLICKHOUSE_CLUSTER_ENABLED for multi-replica deployments unless clusterEnabled is false.
  • Documentation:
    • Updates README.md to clarify clickhouse.clusterEnabled controls CLICKHOUSE_CLUSTER_ENABLED.
  • Testing:
    • Adds clickhouse-cluster_test.yaml to test various configurations of CLICKHOUSE_CLUSTER_ENABLED for web and worker deployments.

This description was created by Ellipsis for 0aeffde. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Helm Unit Test Results

33 tests  +6   33 ✅ +6   2s ⏱️ -1s
 8 suites +1    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a93fac9. ± Comparison against base commit 5359635.

♻️ This comment has been updated with latest results.

@Steffen911 Steffen911 merged commit bac7f22 into main Oct 14, 2025
6 checks passed
@Steffen911 Steffen911 deleted the steffen/patch-cluster-mode-external-ch branch October 14, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant