Skip to content

fix: VariableTruncator._truncate_array under-reports truncated flag #37213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
functionkiller wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix: VariableTruncator._truncate_array under-reports truncated flag #37213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/services/variable_truncator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ def _truncate_array(self, value: list[object], target_size: int) -> _PartResult[
used_size += 1 # Account for comma

if used_size > target_size:
truncated = True
break

remaining_budget = target_size - used_size
Expand All @@ -301,7 +302,7 @@ def _truncate_array(self, value: list[object], target_size: int) -> _PartResult[
raise UnknownTypeError(f"got unknown type {type(item)} in array truncation")
truncated_value.append(part_result.value)
used_size += part_result.value_size
truncated = part_result.truncated
truncated = truncated or part_result.truncated
return _PartResult(truncated_value, used_size, truncated)

@classmethod
Expand Down