Skip to content

Update LogHandler.php#297

Closed
andrewicarlson wants to merge 1 commit intolaravel:1.xfrom
andrewicarlson:patch-1
Closed

Update LogHandler.php#297
andrewicarlson wants to merge 1 commit intolaravel:1.xfrom
andrewicarlson:patch-1

Conversation

@andrewicarlson
Copy link

Today if a log is handled successfully by Nightwatch it doesn't bubble the logs to further channels in the stack.

In it's current state, Nightwatch will not allow logs to bubble to webhook because of it's position in the stack. This means that the order in a .env really matters.

LOG_STACK=single,nightwatch,webhook

Today if a log is handled successfully by Nightwatch it doesn't bubble the logs to further channels in the stack. 

In it's current state, Nightwatch will not allow logs to bubble to `webhook` because of it's position in the stack. This means that the order in a `.env`  _really_ matters.
```
LOG_STACK=single,nightwatch,webhook
```
@timacdonald
Copy link
Member

Hi @andrewicarlson, thanks for your PR.

We are discussing this one internally and will make some adjustments shortly.

@timacdonald
Copy link
Member

#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments