Allow logs to bubble up through other channels in the stack#328
Merged
timacdonald merged 1 commit into1.xfrom Feb 19, 2026
Merged
Allow logs to bubble up through other channels in the stack#328timacdonald merged 1 commit into1.xfrom
timacdonald merged 1 commit into1.xfrom
Conversation
Closed
jessarcher
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #297
Sets a sensible default to allow logs to bubble up through other channels in the stack.
Right now, when Nightwatch captures the log, no subsequent channels will receive the log, e.g.,
In the above example, both
beforeandnightwatchwill get the log, butafterwill not.Allowing the log to bubble up is a saner default for Nightwatch. We can investigate adding configuration for this (see
bubbleoption of Monolog) at a later date if there is demand.