Add sensible fallbacks for NIGHTWATCH_DEPLOY#323
Draft
jradtilbrook wants to merge 2 commits into1.xfrom
Draft
Conversation
jradtilbrook
force-pushed
the
default_deployment_config
branch
from
2a9a4ee to
bf8e368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This configures sensible defaults for
NIGHTWATCH_DEPLOYconfig. Falling back to Laravel Cloud deploy commit and then to Laravel Forge deploy commit if not available.This supersedes #293 which has a few problems that probably make it not viable:
The downside of this PR approach is that this user facing config file looks a bit "off" with these fallbacks. We could move this logic elsewhere to try improve that if desired.