Skip to content

Add sensible fallbacks for NIGHTWATCH_DEPLOY #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jradtilbrook wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Draft

Add sensible fallbacks for NIGHTWATCH_DEPLOY #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ceab9
Set a sensible default deployment config value
jessarcher Oct 21, 2025
bf8e368
Add fallback for NIGHTWATCH_DEPLOY
jradtilbrook Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/nightwatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
return [
'enabled' => env('NIGHTWATCH_ENABLED', true),
'token' => env('NIGHTWATCH_TOKEN'),
'deployment' => env('NIGHTWATCH_DEPLOY'),
'deployment' => env('NIGHTWATCH_DEPLOY', env('LARAVEL_CLOUD_COMMIT', env('FORGE_DEPLOY_COMMIT'))),
'server' => env('NIGHTWATCH_SERVER', (string) gethostname()),
'capture_exception_source_code' => env('NIGHTWATCH_CAPTURE_EXCEPTION_SOURCE_CODE', true),
'capture_request_payload' => env('NIGHTWATCH_CAPTURE_REQUEST_PAYLOAD', false),
Expand Down
62 changes: 62 additions & 0 deletions tests/Unit/CoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use App\Models\User;
use Carbon\CarbonImmutable;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Route;
use Laravel\Nightwatch\ExecutionStage;
use Laravel\Nightwatch\Facades\Nightwatch;
use Orchestra\Testbench\Attributes\WithEnv;
Expand Down Expand Up @@ -89,4 +90,65 @@ public function test_it_ingests_fatal_errors_immediately(): void
],
]);
}

#[WithEnv('NIGHTWATCH_FORCE_REQUEST', '1')]
#[WithEnv('NIGHTWATCH_DEPLOY', '82f35860d8c7e59fe4d81a3256a2bb34c998acd9')]
public function test_it_uses_nightwatch_deploy_env_for_deployments_by_default(): void
{
$ingest = $this->fakeIngest();
Route::get('/test', function () {
return 'OK';
});

$this->get('/test')->assertOk();

$ingest->assertWrittenTimes(1);
$ingest->assertLatestWrite('request:0.deploy', '82f35860d8c7e59fe4d81a3256a2bb34c998acd9');
}

#[WithEnv('NIGHTWATCH_FORCE_REQUEST', '1')]
#[WithEnv('LARAVEL_CLOUD_COMMIT', '92f35860d8c7e59fe4d81a3256a2bb34c998acd9')]
public function test_it_uses_cloud_commit_env_for_deployments_if_available(): void
{
$ingest = $this->fakeIngest();
Route::get('/test', function () {
return 'OK';
});

$this->get('/test')->assertOk();

$ingest->assertWrittenTimes(1);
$ingest->assertLatestWrite('request:0.deploy', '92f35860d8c7e59fe4d81a3256a2bb34c998acd9');
}

#[WithEnv('NIGHTWATCH_FORCE_REQUEST', '1')]
#[WithEnv('FORGE_DEPLOY_COMMIT', '02f35860d8c7e59fe4d81a3256a2bb34c998acd9')]
public function test_it_uses_forge_commit_env_for_deployments_if_available(): void
{
$ingest = $this->fakeIngest();
Route::get('/test', function () {
return 'OK';
});

$this->get('/test')->assertOk();

$ingest->assertWrittenTimes(1);
$ingest->assertLatestWrite('request:0.deploy', '02f35860d8c7e59fe4d81a3256a2bb34c998acd9');
}

#[WithEnv('NIGHTWATCH_FORCE_REQUEST', '1')]
#[WithEnv('FORGE_DEPLOY_COMMIT', '82f35860d8c7e59fe4d81a3256a2bb34c998acd9')]
#[WithEnv('NIGHTWATCH_DEPLOY', '12f35860d8c7e59fe4d81a3256a2bb34c998acd9')]
public function test_it_uses_higher_precedent_deploy_env_for_deployments(): void
{
$ingest = $this->fakeIngest();
Route::get('/test', function () {
return 'OK';
});

$this->get('/test')->assertOk();

$ingest->assertWrittenTimes(1);
$ingest->assertLatestWrite('request:0.deploy', '12f35860d8c7e59fe4d81a3256a2bb34c998acd9');
}
}