Add Nightwatch::digest to proactively transmit events to the agent#330
Open
timacdonald wants to merge 1 commit into1.xfrom
Open
Add Nightwatch::digest to proactively transmit events to the agent#330timacdonald wants to merge 1 commit into1.xfrom
Nightwatch::digest to proactively transmit events to the agent#330timacdonald wants to merge 1 commit into1.xfrom
Conversation
Nightwatch::digest to proactively transmit events to the agent
timacdonald
commented
Feb 19, 2026
| */ | ||
| public function digest(): void | ||
| { | ||
| $this->finishExecution(); |
Member
Author
There was a problem hiding this comment.
Exposing the finishExecution method doesn't make sense from a naming perspective. This isn't going to be used at the end of an execution, but mid-way through.
Nightwatch::digest() is much nicer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a public facing
Nightwatch::digestmethod that mimics thePulse::digestmethod. It proactively transmits any pending events while also respecting sampling, if it has been configured.This is useful in long running processes where you want to dynamically control when an ingest occurs.
Imagine:
In this scenario, one process may do a bunch of work building up events and then the other process might step in and start doing a bunch of work. The events from process the first process may never be transmitted, as they are only transmitted once they reach the event threshold, which defaults to
500events.This PR allows fine-grained control over when events are ingested, e.g.,