Skip to content

Add Nightwatch::digest to proactively transmit events to the agent #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timacdonald wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Add Nightwatch::digest to proactively transmit events to the agent #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ public function guzzleMiddleware(): callable
return new GuzzleMiddleware($this);
}

/**
* @api
*/
public function digest(): void
{
$this->finishExecution();
Copy link
Member Author

@timacdonald timacdonald Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposing the finishExecution method doesn't make sense from a naming perspective. This isn't going to be used at the end of an execution, but mid-way through.

Nightwatch::digest() is much nicer.

}

/**
* @internal
*
Expand Down