Skip to content

Issue2948 motor driver update#4119

Open
JayHuLBL wants to merge 156 commits intomasterfrom
issue2948_MotorDriver_update
Open

Issue2948 motor driver update#4119
JayHuLBL wants to merge 156 commits intomasterfrom
issue2948_MotorDriver_update

Conversation

@JayHuLBL
Copy link
Copy Markdown
Contributor

@JayHuLBL JayHuLBL commented Feb 19, 2025

This is a draft pull request.

@ViswanathanGanesh01 Please see the comments below:

  • Missing comments for instances in the classes, in folder Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.BaseClasses.
  • The base classes do not have documentation and revision note.
  • There still some mixed use of the equation and connections in the equation section. For example, in class Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.SquirrelCage.
  • Run unit test with Optimica, we can still see the following warnings. It shows that some self-connectings. And also, *** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageDrive: Access to component v not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'.
(py3_11_3) jianjunhu@ubuntu:~/GitFolder/modelica-buildings/Buildings$ ../bin/runUnitTests.py -s Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive -t optimica
Regression tests are only run for the following package:
  Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive
Number of models   : 2658
          blocks   : 635
          functions: 222
Using 4 of 4 processors to run unit tests for optimica.
Generated 8 regression tests.

*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageDrive: Access to component v not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageDrive: Access to component i not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageDrive: Access to component theta not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageDrive: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageDrive: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Chiller: Access to component v not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Chiller: Access to component i not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Chiller: Access to component theta not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Chiller: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Chiller: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump: Access to component v not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump: Access to component i not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump: Access to component theta not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageStartUp: Access to component v not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageStartUp: Access to component i not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageStartUp: Access to component theta not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageStartUp: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.InductionMotors.Examples.SquirrelCageStartUp: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.HeatPump: Access to component v not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.HeatPump: Access to component i not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.HeatPump: Access to component theta not recommended, it is not present in constraining type of declaration 'replaceable Buildings.Electrical.Interfaces.BaseTerminal terminal'
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.HeatPump: Ignored connection from connector to itself
*** Warning: Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.HeatPump: Ignored connection from connector to itself
  • Run ../bin/verifyFiles.py , we have the following errors. It means the class does not documentation.
jianjunhu@ubuntu:~/GitFolder/modelica-buildings/Buildings$ ../bin/verifyFiles.py 
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/ThermoFluid/BaseClasses/package.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/ThermoFluid/BaseClasses/Power.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/RotorCurrent_d.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/CurrentBlock.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/CurrentCalculationQ.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/TorqueBlock.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/CurrentCalculationQ_VFD.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/RotorCurrent_q.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/VoltageConversion.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/RMS_Voltage.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/FrequencyConversion.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/SimVFD.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/StatorCurrent_d.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/SpeedBlock.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/CurrentCalculationD.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/StatorCurrent_q.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/CurrentCalculationD_VFD.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/BaseClasses/package.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_10HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/Generic.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_100HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_20HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_20HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_100HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_50HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_200HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_5HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_200HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_5HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_10HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_50HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_150HP_460V_60Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/IM_150HP_400V_50Hz.mo' does not contain required string 'documentation'.
*** Error:  File 'Electrical/AC/ThreePhasesBalanced/Loads/MotorDrive/InductionMotors/Data/package.mo' does not contain required string 'documentation'.
*** Terminating due to found errors in examined files.
  • Classes (except validation and example models) should have defaultComponentName. See for example
  • For all the example and validation models, make sure the .mos script settings are consistent with the one in .mo file. For example, in class Buildings.Electrical.AC.ThreePhasesBalanced.Loads.MotorDrive.Coupled.Examples.Pump, it has annotation (experiment(Tolerance=1e-6,StopTime=600, StartTime=400),. But the corresponding .mos script has tolerance=1e-6,startTime=0, stopTime=200, .

…lanced/Loads/Examples/MotorDrive/InductionMotors/BaseClasses directory
…lanced/Loads/Examples/MotorDrive/InductionMotors/Examples directory
…lanced/Loads/MotorDrive/Coupled/Examples directory
@JayHuLBL JayHuLBL marked this pull request as ready for review October 17, 2025 20:12
Copy link
Copy Markdown
Contributor Author

@JayHuLBL JayHuLBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViswanathanGanesh01 See the inline comments.

@JayHuLBL
Copy link
Copy Markdown
Contributor Author

@ViswanathanGanesh01 It will be ready for Michael to review after the CI tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants