Hybrid air-source heat pump plant controls by AntoineGautier · Pull Request #4369 · lbl-srg/modelica-buildings

AntoineGautier · 2025-09-25T15:47:17Z

This is for #4304.

…to trigger high stages on both heating and cooling modes.

4pipe hp

…totype loads

…ing on 06/17

…rmatting only for changed instances in other components

…rceHeatPumpPlantControls Issue4304 hybrid air source heat pump plant controls

…ssue4304_HybridAirSourceHeatPumpControls

AntoineGautier · 2025-09-25T15:55:31Z

@karthikeyad-pnnl Following our discussion, I've

merged Issue4304 hybrid air source heat pump plant controls #4305 without review
merged the master into issue4304_HybridAirSourceHeatPumpControls
opened this PR against the master.

TODO:

Solve failing CI tests
Develop a closed loop test using Buildings.Fluid.HeatPumps.ModularReversible.TableData2DLoadDepSHC
Check the status of the SOO from the G36 working group

JayHuLBL · 2025-09-30T17:32:05Z

 block AirToWater
  "Controller for AWHP plant"
+
+  final parameter Boolean has_sort=true


change the name, to have_sorRunTim

change the comment: "Set to true if the staging order algorithm includes the sequence of sorting runtime for equipment rotation"

Addressed in #4490

JayHuLBL · 2025-09-30T17:37:18Z

    annotation (Evaluate=true,
    Dialog(group="Plant configuration"));
+
+  parameter Boolean is_fouPip[nHp]=fill(false,nHp)


change comment: "Vector of flag for each heat pump: true - the heat pump is a 4-pipe heat pump"

Addressed in #4490

JayHuLBL · 2025-09-30T17:55:20Z

+    annotation (Evaluate=true,
+    Dialog(group="Plant configuration"));
+
+  final parameter Boolean has_fouPip=Modelica.Math.BooleanVectors.anyTrue(is_fouPip)


change the name to have_fouPip

avoid use the Modelica function Modelica.Math.BooleanVectors.anyTrue, could use sum({if is_fouPip[i] then 1 else 0 for i in 1:nHp})>0

comment: "True: if the plant has any 4-pipe heat pump"

Modified in #4490

JayHuLBL · 2025-09-30T18:11:14Z

    each final max=1,
    each final min=0,
-    each final unit="1")
+    each final unit="1")={fill(0,nHp)}


Do we need the default value here?

Removed in #4490

JayHuLBL · 2025-09-30T18:19:44Z

-    annotation (Dialog(group="Equipment staging and rotation"));
+    annotation (Dialog(group="Equipment staging and rotation", enable=not has_fouPip));
+
+  parameter Real staEquCooHea[:, nHp](


staEquDouMod: double mode

Addressed in #4490

JayHuLBL · 2025-09-30T18:20:06Z

+    "Staging matrix for heating-cooling mode – Equipment required for each stage"
+    annotation (Dialog(group="Equipment staging and rotation", enable=has_fouPip));
+
+  parameter Real staEquOneMod[:, nHp](


staEquSinMod: single mode

Addressed in #4490

JayHuLBL · 2025-09-30T18:26:43Z

    annotation (Placement(transformation(extent={{-10,350},{10,370}})));
-  StagingRotation.StageAvailability avaStaHea(
-    final staEqu=staEqu)
+  StagingRotation.StageAvailability avaStaHea(nSta=nSta, nEqu=nHp)


add final: final nSta=nSta, etc.

Addressed in #4490

JayHuLBL · 2025-09-30T18:33:18Z

+        extent={{-260,-400},{320,400}})),
+    Documentation(
+      info="<html>
+<p>


Is it possible to add a more detailed specification of how the control is implemented?

JayHuLBL · 2025-09-30T18:39:30Z

      coordinateSystem(
        preserveAspectRatio=true,
-        extent={{-200,-360},{200,360}}),
+        extent={{-260,-400},{300,460}}),


The icon layer graphic should be organized.

Addressed in #4490

JayHuLBL · 2025-09-30T18:41:54Z

    Diagram(
      coordinateSystem(
-        extent={{-260,-400},{260,400}})),
+        extent={{-260,-400},{300,460}})),


The diagram layer graphic should be organized to minimize the crosslines and avoid lines above instances.

I could do a more detailed review after the graphic has been improved.

JayHuLBL · 2025-09-30T18:42:32Z

      ="Pa") if is_hdr and is_ctlDp "Loop differential pressure setpoint"
    annotation (Placement(transformation(extent={{-200,-40},{-160,0}}),
        iconTransformation(extent={{-140,-60},{-100,-20}})));
+  Buildings.Controls.OBC.CDL.Reals.Sources.Constant con[nPum,nPum](k=staPum)


missing comment.

Also for the output y1, what if the boolean condition (not is_pri) and (not is_hdr) ?

The Boolean conditions indicate whether the pumps are primary/secondary and whether they are headered/dedicated. The combination you indicate (dedicated+secondary) is not a valid condition present in actual applications. Additionally, users are not anticipated to use this block separately, so I think the current structure should be fine without any assert conditions to enforce correct configurations.

JayHuLBL · 2025-09-30T21:12:16Z

+    annotation (Placement(transformation(extent={{-240,40},{-200,80}}),
+      iconTransformation(extent={{-140,20},{-100,60}})));
+
+  Modelica.Blocks.Sources.RealExpression traMatStaEqu[nEqu, nSta](y=traStaEqu)


Cannot use the blocks that is not in the pacakge Buildings.Controls.OBC.CDL.

Addressed in #4490

JayHuLBL · 2025-09-30T21:12:45Z

    annotation (Evaluate=true);
-  final parameter Real traStaEqu[nEqu, nSta]={{staEqu[i, j] for i in 1:nSta} for j in 1:nEqu}
+
+  final Real traStaEqu[nEqu, nSta]= {{staEqu[i, j] for i in 1:nSta} for j in 1:nEqu}


It has to be a parameter.

Addressed in #4490

JayHuLBL · 2025-09-30T21:23:21Z

+          62,-60},{78,-60}}, color={255,0,255}));
+  connect(u1HeaCoo, cha1.u) annotation (Line(points={{-220,-120},{-180,-120},{
+          -180,-100},{-142,-100}}, color={255,0,255}));
+  connect(cha1.y, swiEna.u[3]) annotation (Line(points={{-118,-100},{-40,-100},{


The input swiEna.u[3] will connect to nothing if is_pumApp is true (the block cha1 will be disabled).

The implementation is intentional. I want the signal swiEna.u[3] to be used only if the plant is a hybrid plant.

JayHuLBL · 2025-09-30T21:25:35Z

    "Staging part load ratio"
    annotation (Dialog(enable=not have_inpPlrSta));
-  final parameter Real traStaEqu[nEqu, nSta]={{staEqu[i, j] for i in 1:nSta} for j in 1:nEqu}
+  final Real traStaEqu[nEqu, nSta]={{staEqu[i, j] for i in 1:nSta} for j in 1:nEqu}


It has to be parameter.

Addressed in #4490

JayHuLBL · 2025-09-30T21:26:10Z

      iconTransformation(extent={{100,-60},{140,-20}})));
-  Buildings.Controls.OBC.CDL.Reals.Sources.Constant traMatStaEqu[nEqu, nSta](
-    final k=traStaEqu)
+  Modelica.Blocks.Sources.RealExpression traMatStaEqu[nEqu, nSta](y=traStaEqu)


Cannot use blocks that are not in the package Buildings.Controls.OBC.CDL.

Addressed in #4490

JayHuLBL

@karthikeyad-pnnl Please see the inline comments.

JayHuLBL · 2026-02-18T21:24:15Z

@karthikeyad-pnnl I merged master to the branch. However, the model Buildings.Templates.Plants.Controls.HeatPumps.AirToWater has checking error as below:

karthikeyad-pnnl · 2026-02-18T21:41:33Z

@JayHuLBL Thanks for the heads-up! I will be submitting a PR this afternoon with some code updates to address comments. I will address the compilation errors then

karthikeyad-pnnl and others added 30 commits January 20, 2025 06:40

Backing up models

7dd0895

Modified models for G36 WG demo

326f279

Added control module classes for hybrid plants

2740a5b

Fixed issues with 4-pipe heat pump staging. Updated validation model …

e2d9622

…to trigger high stages on both heating and cooling modes.

Updated package order files

8865ce8

Added block for calculating reqd flow rate during reset

a9bc9d0

Added type definition for operation modes

2afa35a

Updated validation model

9eeced6

Merge branch 'lbl-srg:master' into master

b48f68e

Merge branch 'lbl-srg:master' into master

d2cd780

Merge branch 'lbl-srg:master' into master

1deec1d

First implementation of the model without checked errors

1f8002b

Complete the first version of the draft model

a4bc96b

Update Modular4Pipe.mo

53bb603

Merge pull request #174 from terrancelu92/4pipeHP

c0a1ac2

4pipe hp

Pulled latest version of flowrate calculator for applying loads

ebb29f2

Backing up files

1d869be

Backing up working example

ba04714

Backing up latest working model

dafd088

Updated flowrate correction method

2a8af62

Updated heating scenario. Cooing scenario in progress

f701012

Backing up plotting script

12a4894

Backing files up after analysis for WG discussion

f70b4cb

Backing up file with multiple table sources

e42e1d3

Updated simultaneous heating-cooling mode operation

c7c8aa7

Updated plotting script

942577c

Backing up attempt to find simulataneous heating and cooling from pro…

4b92880

…totype loads

Backing up new heat pump plant classes

db7be13

Pushing latest files to Github repo after generating results for meet…

3621003

…ing on 06/17

Pushing plot script

7c1c4e5

karthikeyad-pnnl and others added 5 commits July 31, 2025 07:47

Updated stage availability validation to resolve unit test errors

81b6dc1

Updated formatting for new blocks to meet OBC conventions. Updated fo…

e27f849

…rmatting only for changed instances in other components

Removed excess parameter

f161d90

Merge pull request #4305 from karthikeyad-pnnl/issue4304_HybridAirSou…

20b2713

…rceHeatPumpPlantControls Issue4304 hybrid air source heat pump plant controls

Merge branch 'master' of github.com:lbl-srg/modelica-buildings into i…

c0cb537

…ssue4304_HybridAirSourceHeatPumpControls

AntoineGautier assigned AntoineGautier and unassigned AntoineGautier Sep 25, 2025

AntoineGautier mentioned this pull request Sep 25, 2025

Issue4304 hybrid air source heat pump plant controls #4305

Merged

JayHuLBL reviewed Sep 30, 2025

View reviewed changes

JayHuLBL requested changes Sep 30, 2025

View reviewed changes

merged master [ci skip]

5597c42

karthikeyad-pnnl mentioned this pull request Mar 4, 2026

Issue4304 hybrid air source heat pump plant controls #4490

Open

Conversation

AntoineGautier commented Sep 25, 2025

Uh oh!

AntoineGautier commented Sep 25, 2025

Uh oh!

JayHuLBL Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayHuLBL Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayHuLBL Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayHuLBL Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayHuLBL Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayHuLBL left a comment

Choose a reason for hiding this comment

Uh oh!

JayHuLBL commented Feb 18, 2026

Uh oh!

JayHuLBL Sep 30, 2025 •

edited

Loading

JayHuLBL Sep 30, 2025 •

edited

Loading

JayHuLBL Sep 30, 2025 •

edited

Loading

JayHuLBL Sep 30, 2025 •

edited

Loading

JayHuLBL Sep 30, 2025 •

edited

Loading