Optimize grand product eq #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hm good point indeed, thanks. Originally this takes 5ms on my laptop. I have added parallelism + SIMD on your PR (otherwise it was > 150ms). But even with this we are still above 10ms, i.e. slower than the current implem. My guess is that there are some inefficiencies in |
Contributor
Author
|
umm same as my laptop(Macbook), I'll check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimized the process of evaluating execution tables in Grand Product's sumcheck, ensuring that the weights of the polynomial equations are calculated only once and reused for each column.