Skip to content

Optimize grand product eq #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adust09 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Optimize grand product eq #82

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b813552
Refactor prove_execution to compute grand product execution equality …
adust09 Oct 25, 2025
a53dc3a
Merge branch 'main' into feat/-optimize-grand-product-eq
adust09 Oct 28, 2025
ecce8d1
Refactor dot product computation in prove_execution for improved read…
adust09 Oct 28, 2025
7bc6499
multi-threaded + SIMD
TomWambsgans Oct 28, 2025
9bb6ffa
Merge remote-tracking branch 'origin/main' into feat/-optimize-grand-…
adust09 Oct 30, 2025
b1956fe
Merge remote-tracking branch 'origin/main' into feat/-optimize-grand-…
adust09 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/lean_prover/src/prove_execution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ pub fn prove_execution(
)
});

// TODO compute eq polynomial 1 time and then inner product with each column
let grand_product_exec_eq_weights = eval_eq_packed(&grand_product_exec_sumcheck_point);
for col in [
COL_INDEX_OPERAND_C,
COL_INDEX_ADD,
Expand All @@ -523,7 +523,10 @@ pub fn prove_execution(
] {
grand_product_exec_sumcheck_inner_evals.insert(
col,
full_trace[col].evaluate(&grand_product_exec_sumcheck_point),
dot_product_ef_packed_par(
&grand_product_exec_eq_weights,
FPacking::<F>::pack_slice(&full_trace[col]),
),
);
}
assert_eq!(
Expand Down
Loading