[Merged by Bors] - feat: register mathlib tactics with try? #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
force-pushed
the
add-try-registrations
branch
from
9d26e23 to
2fbf413
Compare
Register a selection of mathlib finishing tactics with the `try?` tactic: - Common finishing tactics: tauto, aesop, fun_prop - Domain-specific finishing tactics: norm_num, noncomm_ring, field, bound, finiteness, compute_degree, positivity, field_simp These tactics are registered alongside the existing `hint` registrations to make them available to the built-in `try?` tactic in Lean 4.27.0+. 🤖 Prepared with Claude Code
kim-em
force-pushed
the
add-try-registrations
branch
from
2fbf413 to
3d04a0d
Compare
…ty/mathlib4-nightly-testing into add-try-registrations
Author
|
This PR is now blocked on leanprover/lean4#11547, which fixes the linter errors by marking the auto-generated Once that PR merges and appears in nightly-2025-12-08 (or later), this PR should pass without any changes. |
Author
|
Waiting on #137 to be merged first. Edit: done now. |
Author
|
I'm going to take LGTM from Johan on Zulip as a bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
This PR adds `register_try?_tactic` calls for all finishing tactics currently registered with `register_hint`, which are not already covered by `grind` modules (i.e. I have not registered `linarith` or `ring`), using identical priority values: **Common tactics** (Common.lean): - tauto (priority 500) - aesop (priority 80) - fun_prop (priority 200) **Domain-specific tactics**: - norm_num (1000), noncomm_ring (1000) - field (850), bound (70) - finiteness (1000), compute_degree (1000), positivity (1000), field_simp (1000) 🤖 Prepared with Claude Code
|
This PR was included in a batch that successfully built, but then failed to merge into bump/v4.27.0 (it was a non-fast-forward update). It will be automatically retried. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
This PR adds `register_try?_tactic` calls for all finishing tactics currently registered with `register_hint`, which are not already covered by `grind` modules (i.e. I have not registered `linarith` or `ring`), using identical priority values: **Common tactics** (Common.lean): - tauto (priority 500) - aesop (priority 80) - fun_prop (priority 200) **Domain-specific tactics**: - norm_num (1000), noncomm_ring (1000) - field (850), bound (70) - finiteness (1000), compute_degree (1000), positivity (1000), field_simp (1000) 🤖 Prepared with Claude Code
|
Build failed: |
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
This PR adds `register_try?_tactic` calls for all finishing tactics currently registered with `register_hint`, which are not already covered by `grind` modules (i.e. I have not registered `linarith` or `ring`), using identical priority values: **Common tactics** (Common.lean): - tauto (priority 500) - aesop (priority 80) - fun_prop (priority 200) **Domain-specific tactics**: - norm_num (1000), noncomm_ring (1000) - field (850), bound (70) - finiteness (1000), compute_degree (1000), positivity (1000), field_simp (1000) 🤖 Prepared with Claude Code
|
Pull request successfully merged into bump/v4.27.0. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
register_try?_tacticcalls for all finishing tactics currently registered withregister_hint, which are not already covered bygrindmodules (i.e. I have not registeredlinarithorring), using identical priority values:Common tactics (Common.lean):
Domain-specific tactics:
🤖 Prepared with Claude Code