Skip to content

refactor: make CCPO class Prop-valued #11425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nomeata merged 8 commits into from
Dec 4, 2025
Merged

refactor: make CCPO class Prop-valued #11425

nomeata merged 8 commits into from
Dec 4, 2025

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Nov 28, 2025 •
edited
Loading

This PR changes Lean.Order.CCPO and .CompleteLattice to carry a Prop. This avoids the CCPO IO instance from being noncomputable.

@nomeata
refactor: make CCPO class Prop-valued
9f30a23 
This PR changes Lean.Order.CCPO to carry a Prop. This way fewer
instances have to be noncomputable.
@nomeata nomeata added the changelog-language Language features and metaprograms label Nov 28, 2025
Rob23oba
Rob23oba reviewed Nov 29, 2025
View reviewed changes
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 1, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-11-29 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-01 10:02:52)
  • ✅ Mathlib branch lean-pr-testing-11425 has successfully built against this PR. (2025-12-02 19:04:05) View Log

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 1, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-11-29 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-01 10:02:54)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-02 18:02:14)

@nomeata nomeata marked this pull request as ready for review December 2, 2025 16:55
@nomeata nomeata added the will-merge-soon …unless someone speaks up label Dec 2, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 2, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11425
b5e2afe
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 2, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11425
13fb43b
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 2, 2025
@nomeata nomeata added this pull request to the merge queue Dec 4, 2025
Merged via the queue into master with commit d60ef53 Dec 4, 2025
22 checks passed
algebraic-dev pushed a commit that referenced this pull request Dec 8, 2025
@nomeata @algebraic-dev
refactor: make CCPO class Prop-valued (#11425)
b1ec186 
This PR changes `Lean.Order.CCPO` and `.CompleteLattice` to carry a
Prop. This avoids the `CCPO IO` instance from being `noncomputable`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Rob23oba Rob23oba Rob23oba left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nomeata @leanprover-community-bot @leanprover-bot @Rob23oba