fix: mark ByteArray.Iterator Inhabited instance as noncomputable #11504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compiler error where
ByteArray.Iterator's derivedInhabitedinstance conflicts with its customSizeOfinstance that computes size from runtime array values.Changes
deriving InhabitedfromByteArray.Iteratorstructurenoncomputable instance : Inhabited Iteratorwith documentation explaining the dependency on runtimeSizeOfThe custom
SizeOfinstance computesi.array.size - i.idx, making anyInhabitedinstance necessarily noncomputable. The previousderiving Inhabitedattempted to generate a computable instance, causing the compiler error.Related: https://leanprover.zulipchat.com/#narrow/channel/113489-new-members/topic/Compiler.20error.20with.20sizeOf/with/561532734
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.