Skip to content

fix: mark ByteArray.Iterator Inhabited instance as noncomputable #11504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

fix: mark ByteArray.Iterator Inhabited instance as noncomputable #11504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cba30de
Initial plan
Copilot Dec 4, 2025
f9586f1
fix: mark ByteArray.Iterator Inhabited instance as noncomputable
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Init/Data/ByteArray/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,12 @@ structure Iterator where
`Iterator.next` when `Iterator.atEnd` is true. If the position is not valid, then the
current byte is `(default : UInt8)`. -/
idx : Nat
deriving Inhabited
set_option doc.verso true

/-- Noncomputable because it depends on the custom `SizeOf` instance which uses runtime array size. -/
noncomputable instance : Inhabited Iterator where
default := ⟨default, default⟩

/-- Creates an iterator at the beginning of an array. -/
def mkIterator (arr : ByteArray) : Iterator :=
⟨arr, 0⟩
Expand Down