fix: handle dot notation on local variables in grind parameters #11573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
grindrejecting dot notation terms, mistaking them for local hypotheses.When a grind parameter like
n.trivis given, wherenis a local variable andtrivis a theorem that takesnas an argument (son.trivmeansNat.triv n), grind was incorrectly rejecting it with "redundant parameter" because it detected that the identifier resolved to a local variable viaresolveLocalName.The fix checks if
resolveLocalNamereturns field projections (non-empty list), indicating dot notation. In that case, we process the parameter as a term expression to let elaboration resolve the dot notation properly, rather than trying to resolve it as a global constant name.Minimal reproducer
This also fixes the issue where
grind [x.exp_pos]was rejected even thoughx.exp_poselaborates toReal.exp_pos x, a valid theorem application.🤖 Prepared with Claude Code